GNOME Bugzilla – Bug 708103
Playing default playlist is broken
Last modified: 2013-09-16 14:11:48 UTC
I broke this during the search merge, so here's the fix.
Created attachment 254960 [details] [review] player: No next/previous track if there is no playlist Fixes Play on MPRIS when there is no playlist.
Playing default playlist still crashes for me: 1) If I'm not on Songs view - crash: Traceback (most recent call last):
+ Trace 232488
model.disconnect(self.first_song_handler)
return func(_get_instance_for_signal(obj), *args, **kwargs)
2) If I'm on Songs view, then g-m keeps on trying to play first song (which is undiscoverable) - and doesn't move on
(In reply to comment #2) > Playing default playlist still crashes for me: > > 2) If I'm on Songs view, then g-m keeps on trying to play first song (which is > undiscoverable) - and doesn't move on > I think this is a different bug though, this would happen too when all files get deleted on disk - Music will be in an infinite loop if in repeat all, repeat song or shuffle mode.
Created attachment 255021 [details] [review] mpris: Use filter instead of the view model
Review of attachment 255021 [details] [review]: +1, but it still doesn't fix problem 2) - g-m is stuck on the same song instead of skipping it
Comment on attachment 254960 [details] [review] player: No next/previous track if there is no playlist Committed as 37e7e12.
Comment on attachment 255021 [details] [review] mpris: Use filter instead of the view model Committed as da1bc54.
(In reply to comment #5) > Review of attachment 255021 [details] [review]: > > +1, but it still doesn't fix problem 2) - g-m is stuck on the same song instead > of skipping it I'll file another bug report for this.