After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708102 - Thumbnail no longer shows up in MPRIS clients
Thumbnail no longer shows up in MPRIS clients
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.10
Assigned To: Arnel Borja
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-15 05:27 UTC by Arnel Borja
Modified: 2013-09-16 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
player: Add new signal for thumbnail update (1.30 KB, patch)
2013-09-15 05:27 UTC, Arnel Borja 		committed Details | Review
albumArtCache: Save thumbnail path as URI (904 bytes, patch)
2013-09-15 05:27 UTC, Arnel Borja 		committed Details | Review
mpris: Send PropertiesChanged signal when thumbnail is updated (2.18 KB, patch)
2013-09-15 05:27 UTC, Arnel Borja 		committed Details | Review

Description Arnel Borja 2013-09-15 05:27:15 UTC 
We no longer resolve the thumbnail upon querying of files, so we have to update the metadata sent to MPRIS once the thumbnail is available.
Comment 1 Arnel Borja 2013-09-15 05:27:17 UTC 
Created attachment 254957 [details] [review]
player: Add new signal for thumbnail update

We no longer resolves the thumbnail path when populating the views, so
get_thumbnail() is unusable on all media on first play.

This opens a way to tell when the thumbnail becomes available.
Comment 2 Arnel Borja 2013-09-15 05:27:32 UTC 
Created attachment 254958 [details] [review]
albumArtCache: Save thumbnail path as URI
Comment 3 Arnel Borja 2013-09-15 05:27:48 UTC 
Created attachment 254959 [details] [review]
mpris: Send PropertiesChanged signal when thumbnail is updated

Resends the metadata when the thumbnail is updated. We could send just
the mpris:artUrl key, but some clients ignore metadata that contains
only one key (some music players send a dummy value on stop), so send
all metadata to be safe.
Comment 4 Vadim Rutkovsky 2013-09-16 07:54:01 UTC 
Review of attachment 254957 [details] [review]:

Great job,thanks!
Comment 5 Vadim Rutkovsky 2013-09-16 07:54:26 UTC 
Review of attachment 254958 [details] [review]:

Approved
Comment 6 Vadim Rutkovsky 2013-09-16 07:54:54 UTC 
Review of attachment 254959 [details] [review]:

Thanks, looks good to me
Comment 7 Arnel Borja 2013-09-16 08:44:27 UTC 
Comment on attachment 254957 [details] [review]
player: Add new signal for thumbnail update

Committed as 5b4008cf.
Comment 8 Arnel Borja 2013-09-16 08:44:57 UTC 
Comment on attachment 254958 [details] [review]
albumArtCache: Save thumbnail path as URI

Committed as c86ed03f.
Comment 9 Arnel Borja 2013-09-16 08:45:32 UTC 
Comment on attachment 254959 [details] [review]
mpris: Send PropertiesChanged signal when thumbnail is updated

Committed as 4fe07564.