After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708096 - gettext-0.18.3.1 doesn't extract some strings
gettext-0.18.3.1 doesn't extract some strings
Status: RESOLVED NOTABUG
Product: gnome-shell
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-15 00:34 UTC by Piotr Drąg
Modified: 2013-12-31 21:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Piotr Drąg 2013-09-15 00:34:30 UTC
The following strings are not extracted to the POT file when running intltool-update with gettext-0.18.3.1-1.fc20.x86_64:

https://git.gnome.org/browse/gnome-shell/tree/js/ui/status/keyboard.js#n403 ("Show Keyboard Layout")

https://git.gnome.org/browse/gnome-shell/tree/js/extensionPrefs/main.js#n125 ("There was an error loading the preferences dialog for %s:")

https://git.gnome.org/browse/gnome-shell/tree/js/extensionPrefs/main.js#n165 ("Extension")
Comment 1 Piotr Drąg 2013-09-20 15:43:41 UTC
This is an another string that doesn't get extracted:

https://git.gnome.org/browse/gnome-shell/tree/js/extensionPrefs/main.js#n153 ("GNOME Shell Extension Preferences")

And more importantly, these two strings get extracted differently using 0.18.3.1 and an older version:

https://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js#n75

gettext-0.18.3.1 changes \u2236 into "∶" unicode character, so if the translation was done using an older gettext (and 99% are), these strings get fuzzy and appear untranslated in the UI. And that's pretty bad.
Comment 2 Piotr Drąg 2013-09-27 14:17:50 UTC
Please ignore the issue in power.js, it got fixed by a new gettext on damned-lies. The others are still valid though. :(
Comment 3 Allison Karlitskaya (desrt) 2013-09-27 14:18:57 UTC
fwiw, the behaviour of gettext-0.18.3.1 on the last point is correct.  If it doesn't unescape the Unicode escapes then the string is truly untranslated (as determined by what gettext() will return at runtime).

No comment on the other issue.  Regression in new gettext extraction?  Not likely a bug in the shell, in any case.
Comment 4 Piotr Drąg 2013-09-27 14:53:04 UTC
I've filed a bug in upstream gettext: https://savannah.gnu.org/bugs/index.php?40125
Comment 5 Piotr Drąg 2013-12-31 21:27:50 UTC
gettext got fixed upstream in master, but in the meantime gjs/gnome-shell stopped using E4X. Oh well.