After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708085 - Remove the mnemonic-widget property from the "Click Assist" GtkLabel
Remove the mnemonic-widget property from the "Click Assist" GtkLabel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Universal Access
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-14 20:44 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-09-16 11:49 UTC
See Also:
GNOME target: 3.10
GNOME version: ---


Attachments
proposed patch (1.16 KB, patch)
2013-09-14 20:44 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
datetime: Remove incorrectly set mnemonics (1.56 KB, patch)
2013-09-16 01:13 UTC, Kalev Lember
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-09-14 20:44:13 UTC
Created attachment 254947 [details] [review]
proposed patch

Currently the mnemonic widget of the heading_click_assist GtkLabel is the value_click_assist GtkLabel.

Aside from the fact that the mnemonic widget is expected to be an activatable widget, the fact that this property is set causes Gtk's accessibility support to set a label-for/labelled-by AtkRelation pair. And that, in turn, causes Orca to conclude that the labels are not static text, but instead something that should be presented in conjunction with an activatable widget. That widget doesn't exist and thus the labels never get presented.

Long term, I suppose I should give some thought to how Orca should handle labels which claim to label other labels. In the meantime, can we just remove this property? :)
Comment 1 Kalev Lember 2013-09-16 01:11:57 UTC
The Date & Time panel has a similar problem with two of its rows where Orca doesn't speak.
Comment 2 Kalev Lember 2013-09-16 01:13:11 UTC
Created attachment 254998 [details] [review]
datetime: Remove incorrectly set mnemonics

The mnemonics were pointing to other GtkLabels rather than activatable
widgets and were confusing Orca.
Comment 3 Joanmarie Diggs (IRC: joanie) 2013-09-16 08:00:56 UTC
I think this should be a blocker for 3.10. The fix is safe and makes the items in question accessible.
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-09-16 10:40:39 UTC
(In reply to comment #3)
> I think this should be a blocker for 3.10. The fix is safe and makes the items
> in question accessible.

I agree.
Comment 5 Rui Matos 2013-09-16 11:36:03 UTC
Review of attachment 254998 [details] [review]:

ok
Comment 6 Rui Matos 2013-09-16 11:36:09 UTC
Review of attachment 254947 [details] [review]:

ok
Comment 8 Kalev Lember 2013-09-16 11:49:27 UTC
Attachment 254998 [details] pushed as 9fface8 - datetime: Remove incorrectly set mnemonics