After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708080 - The accessible name of the "Settings" menu should not include "Menu"
The accessible name of the "Settings" menu should not include "Menu"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-14 17:51 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-09-14 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (805 bytes, patch)
2013-09-14 17:51 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-09-14 17:51:48 UTC
Created attachment 254928 [details] [review]
proposed patch

When presenting the new system-status menu, Orca says "Settings Menu menu" because "Menu" is part of the accessible name and "menu" is the accessible role. Unless there is a reason why "Menu" needs to remain there, it would be awesome to remove it.

On a related note, "Settings" is already amongst gnome-shell's localized strings, so making this change is not a String Freeze break.

  #: ../js/ui/backgroundMenu.js:19 ../js/ui/status/system.js:325
  msgid "Settings"
  msgstr ""
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-14 17:56:59 UTC
Review of attachment 254928 [details] [review]:

OK.
Comment 2 Joanmarie Diggs (IRC: joanie) 2013-09-14 18:11:30 UTC
Comment on attachment 254928 [details] [review]
proposed patch

Thanks!

https://git.gnome.org/browse/gnome-shell/commit/?id=3691e8ddd75889791a5d3e6aa2518fb5ceda5d71
Comment 3 Joanmarie Diggs (IRC: joanie) 2013-09-14 18:12:26 UTC
Comment on attachment 254928 [details] [review]
proposed patch

Thanks!

https://git.gnome.org/browse/gnome-shell/commit/?id=3691e8ddd75889791a5d3e6aa2518fb5ceda5d71