After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708055 - sharing: Forcefully enable the MediaExport plugin
sharing: Forcefully enable the MediaExport plugin
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-14 02:10 UTC by Bastien Nocera
Modified: 2013-10-02 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sharing: Forcefully enable the MediaExport plugin (1.31 KB, patch)
2013-09-14 02:11 UTC, Bastien Nocera
reviewed Details | Review

Description Bastien Nocera 2013-09-14 02:10:59 UTC
Otherwise, media export is disabled, and rygel-preferences
shows that media sharing is disabled.
Comment 1 Bastien Nocera 2013-09-14 02:11:01 UTC
Created attachment 254900 [details] [review]
sharing: Forcefully enable the MediaExport plugin

When enabling DLNA, also make sure to enable the plugin that
we use to export the media to the TV or set-top-box, otherwise
rygel won't export anything.
Comment 2 Giovanni Campagna 2013-09-14 10:22:13 UTC
Actually, the MediaExport plugin should be disabled (or in any case it disables itself automatically), because Rygel should use the Tracker plugin instead.
Comment 3 Bastien Nocera 2013-09-15 11:32:20 UTC
(In reply to comment #2)
> Actually, the MediaExport plugin should be disabled (or in any case it disables
> itself automatically), because Rygel should use the Tracker plugin instead.

No it shouldn't. We've discussed this time and time again with the designers, and neither them nor I want to export whatever you have in your Videos folder (and indexed by Tracker) on the local network.

This is made worse by the fact that disabling indexing on a particular directory doesn't make Tracker remove the items from its database.

What's indexed and searchable locally isn't the same as what should be offered remotely.
Comment 4 Giovanni Campagna 2013-09-15 13:43:56 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Actually, the MediaExport plugin should be disabled (or in any case it disables
> > itself automatically), because Rygel should use the Tracker plugin instead.
> 
> No it shouldn't. We've discussed this time and time again with the designers,
> and neither them nor I want to export whatever you have in your Videos folder
> (and indexed by Tracker) on the local network.
> 
> This is made worse by the fact that disabling indexing on a particular
> directory doesn't make Tracker remove the items from its database.
> 
> What's indexed and searchable locally isn't the same as what should be offered
> remotely.

Oh really? But doesn't that go against the proposition of hiding the file system from the user, and creating libraries that span on different folders, disks and locations?
Personally, I like the fact that my music, no matter where it is stored, can be accessed in the same way from gnome-music and from my phone through upnp.
Comment 5 Bastien Nocera 2013-09-15 13:57:41 UTC
File a new bug about finding a new way to share specific audio/video libraries/playlists. Discussions of rearchitecturing is kind of irrelevant for a bug fix to GNOME 3.8 though.
Comment 6 Giovanni Campagna 2013-09-15 14:00:34 UTC
(In reply to comment #5)
> File a new bug about finding a new way to share specific audio/video
> libraries/playlists. Discussions of rearchitecturing is kind of irrelevant for
> a bug fix to GNOME 3.8 though.

Yeah, but IMHO, the easy (3.8/3.10) bug fix is to enable Tracker, not MediaExport...
Anyway, I expressed my opinion, so I won't block this any further.
Comment 7 Bastien Nocera 2013-09-15 14:13:12 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > File a new bug about finding a new way to share specific audio/video
> > libraries/playlists. Discussions of rearchitecturing is kind of irrelevant for
> > a bug fix to GNOME 3.8 though.
> 
> Yeah, but IMHO, the easy (3.8/3.10) bug fix is to enable Tracker, not
> MediaExport...

That's not the way it was designed or implemented for 3.8/3.10.
Comment 8 Thomas Wood 2013-10-02 14:31:22 UTC
Review of attachment 254900 [details] [review]:

The list of shared folders is currently set for the MediaExport plugin, so it makes sense to ensure it is enabled.

::: panels/sharing/cc-media-sharing.c
@@ +123,2 @@
   if (enabled)
+   *enabled = g_key_file_get_boolean (file, "MediaExport", "enabled", NULL);

Shouldn't "enabled" depend on both "MediaExport" and "upnp-enabled" keys being true?
Comment 9 Bastien Nocera 2013-10-02 15:52:32 UTC
Pushed with the change mentioned.

Attachment 254900 [details] pushed as 1ae79d7 - sharing: Forcefully enable the MediaExport plugin