After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708031 - telephatyIdle: Time stamps next conversation line
telephatyIdle: Time stamps next conversation line
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-13 14:31 UTC by Carlos Soriano
Modified: 2014-02-17 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
telephatyIdle: Time stamps next conversation line (5.20 KB, patch)
2013-09-13 14:31 UTC, Carlos Soriano
reviewed Details | Review
Timestamp next to converstaion line (236.53 KB, image/png)
2013-09-13 14:35 UTC, Carlos Soriano
  Details
telephatyIdle: Time stamps next conversation line (5.06 KB, patch)
2014-02-09 11:26 UTC, Carlos Soriano
committed Details | Review

Description Carlos Soriano 2013-09-13 14:31:10 UTC
Give more context to the chat notification bubble, put the
time stamp next to the last conversation line instead of
a new line
Comment 1 Carlos Soriano 2013-09-13 14:31:13 UTC
Created attachment 254865 [details] [review]
telephatyIdle: Time stamps next conversation line

To give more context to the chat notification bubble, put the
time stamp next to the last conversation line instead of
a new line.
Comment 2 Carlos Soriano 2013-09-13 14:35:24 UTC
Created attachment 254866 [details]
Timestamp next to converstaion line
Comment 3 Giovanni Campagna 2013-09-13 14:45:44 UTC
Uhm... so a timestamp for each line, including consecutive runs from the same person?
Is this by design?

(Also, is this UI freeze worthy? I personally don't think so)
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-09-13 14:47:58 UTC
It also breaks string freeze, which is unfortunate, but a no-go at this point.
Comment 5 Carlos Soriano 2013-09-13 14:51:51 UTC
(In reply to comment #3)
> Uhm... so a timestamp for each line, including consecutive runs from the same
> person?
> Is this by design?
> 
> (Also, is this UI freeze worthy? I personally don't think so)

Ei, sorry for the confusion, it was just to show designers how it looks, (so I change temporaly to do the screenshot the timestamp timeout to 10 seconds)
But no, just only when needed.

um, so commit after freeze?
Comment 6 Carlos Soriano 2013-09-13 14:52:33 UTC
(In reply to comment #4)
> It also breaks string freeze, which is unfortunate, but a no-go at this point.

it is so bad? I mean, can we just put it for commit after freeze? or is there a problem?
Comment 7 Jasper St. Pierre (not reading bugmail) 2014-02-07 14:37:10 UTC
Review of attachment 254865 [details] [review]:

::: js/ui/components/telepathyClient.js
@@ +975,3 @@
+        // Get the boxLayout of the last conversation line and add
+        // the timestamp next the conversation line
+        let messageBoxLayout = this._history[0].actor.get_parent();

ugh, why can't you just use lastGroupActor?
Comment 8 Carlos Soriano 2014-02-09 11:26:18 UTC
Created attachment 268567 [details] [review]
telephatyIdle: Time stamps next conversation line

To give more context to the chat notification bubble, put the
time stamp next to the last conversation line instead of
a new line.
Comment 9 Carlos Soriano 2014-02-09 11:28:14 UTC
Since we don't have lastGroupActor anymore, I added a new var called lastMessageBox.
Comment 10 drago01 2014-02-17 13:31:17 UTC
Review of attachment 268567 [details] [review]:

Looks good just them one string should probably be translateable.

::: js/ui/components/telepathyClient.js
@@ +945,3 @@
         // Show only the hour if date is on today
         if(daysAgo < 1){
+            format = "%H:%M";

Why is this not translate able? If this is the intent then use single quotes.
Comment 11 Carlos Soriano 2014-02-17 19:26:30 UTC
Attachment 268567 [details] pushed as fff2ca6 - telephatyIdle: Time stamps next conversation line