After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708027 - query cannot be used when looking up media factories
query cannot be used when looking up media factories
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-13 12:53 UTC by Jonas Holmberg
Modified: 2014-06-22 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
made match() vmethod that takes url (11.11 KB, patch)
2013-09-13 12:55 UTC, Jonas Holmberg
none Details | Review

Description Jonas Holmberg 2013-09-13 12:53:12 UTC
A subclass to GstRTSPMountPoints cannot override the default behaviour of _match() to use the path+query instead of just patch when looking up a media factory.
Comment 1 Jonas Holmberg 2013-09-13 12:55:08 UTC
Created attachment 254857 [details] [review]
made match() vmethod that takes url

Made match() virtual and changed the path argument to url to make it possible to use the query string in the url when looking up factories.
Comment 2 Wim Taymans 2013-09-16 14:32:22 UTC
It not right yet.. The problem is that if you use the query parameters to find the factory, the logic to cache the factory (that only works on the matched part of the original uri) doesn't work anymore.

I think what you want is to have a *separate* method to transform the URI into a mount path and then use that mount path to find and cache the factory.
Comment 3 Wim Taymans 2013-09-16 15:18:16 UTC
Maybe this:

commit e3fded2cec897a2ec003450607b916cc1601fd2d
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Sep 16 17:16:49 2013 +0200

    client: map URL to path in requests

commit 952aa309dcfc8389fc51b119d984407d7f75f34f
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Sep 16 16:47:40 2013 +0200

    mount-points: make vmethod to make path from uri
    
    Make a vmethod to transform an url into a path. The path is then used to lookup
    the factory. This makes it possible to also use other bits of the url, such as
    the query parameters, to locate the factory.
Comment 4 Jonas Holmberg 2013-09-16 16:43:14 UTC
(In reply to comment #3)
> Maybe this:

Yeah, that's better. Will test it first thing tomorrow.
Comment 5 Jonas Holmberg 2013-09-17 07:51:42 UTC
It works fine.