Created attachment 254775 [details] [review]
Initial patch with city images support to begin with

Created attachment 254777 [details] [review]
Initial patch with city images support to begin with

One of the implementation ideas, discussed on irc:

<pbor> I was more inclined toward the solution where the provider is only used for downloading and browsing custom images
<pbor> but the actual code in the iconview etc is not aware of the providers
<pbor> it just sees an additional "image" property in the serialized setting
<pbor> and loads it from file
<pbor> falling back to the default night and day image if the property is not set or the file not present
<pbor> the providers would only be used from the standalone "setup" dialog and when adding a new clock, to browse images and pick one
<pbor> once you pick one it is downloaded and saved locally
<pbor> so only the setup dialog would "speak" with the providers
<pbor> but maybe your idea is better, I have to think about it
<pbor> mine is more conservative and less intrusive for the current code

The new design got rid of that feature.