After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707953 - secret agent doesn't work when gnome-shell without networkmanager support is running
secret agent doesn't work when gnome-shell without networkmanager support is ...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: Pavel Simerda
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-12 08:00 UTC by Pavel Simerda
Modified: 2015-06-11 01:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to stop checking for gnome shell (3.99 KB, patch)
2014-05-23 14:02 UTC, Pavel Simerda 		none Details | Review
patch to avoid checking for gnome shell version (2.93 KB, patch)
2014-11-22 21:10 UTC, Pavel Simerda 		none Details | Review

Description Pavel Simerda 2013-09-12 08:00:42 UTC 
Gnome Shell can be built without networkmanager support and then nm-applet is the only chance to supply connection credentials (until nmcli is ready for that). Unfortunately, nm-applet doesn't detect the presence of a secret agent but rather detects gnome-shell.
Comment 1 Dan Winship 2013-09-12 14:14:43 UTC 
nm-applet is no longer autostarted under GNOME, so we could just remove the shell-detecting code now
Comment 2 Pavel Simerda 2013-09-12 17:45:28 UTC 
I'll post a patch for that then, unless anyone is quicker than me.
Comment 3 Pavel Simerda 2014-05-23 14:02:27 UTC 
Created attachment 277064 [details] [review]
patch to stop checking for gnome shell

A bit late (not using Gnome 3 any more) but here it is. This can help people who run Gnome 3 without network-indicator who prefer to use nm-applet.
Comment 4 Thomas Haller 2014-05-23 16:32:42 UTC 
I think in general, nm-applet should just work -- even in the presence of other NM clients. So, I agree with this patch.

I think, we could also completely remove:

src/shell-watcher.c
src/shell-watcher.h
Comment 5 Pavel Simerda 2014-05-25 13:33:57 UTC 
(In reply to comment #4)
> I think, we could also completely remove:
> 
> src/shell-watcher.c
> src/shell-watcher.h

+1
Comment 6 Dan Williams 2014-06-05 22:14:00 UTC 
Patch looks OK, but please don't remove the parts for "--shell-debug" support, since that's critical to debugging the applet when also running GNOME Shell.

GNOME Shell has a blacklist for notification area applets, and nm-applet is in that list because it conflicts with GNOME shell's agent.  So unless we keep the shell-debug bits, when running the applet under the shell so that we can develop/debug it, theres no way to click on the applet or get it to show up.  Using --shell-debug you can see it in the notification area in the lower-right corner.
Comment 7 Pavel Simerda 2014-11-22 21:10:54 UTC 
Created attachment 291279 [details] [review]
patch to avoid checking for gnome shell version

I'm not sure how the --shell-debug code works, so please let me know if I got it wrong.
Comment 8 Dan Williams 2014-11-24 16:48:58 UTC 
Pushed with some fixups for removal of shell-watcher.*.

4473e6a48fcfda1d87d4a4bc9f5c0589235dcfe0
applet: don't check for gnome shell (bgo #707953)
Comment 9 Dan Williams 2014-11-24 16:55:22 UTC 
2014927869cb92be2c9e360f1a6a4b118b866403
build: fix build after "applet: don't check for gnome shell (bgo #707953)"
Comment 10 Lonnie Best 2015-06-11 01:30:15 UTC 
I started having this issue again recently.

Ubuntu 15.04 worked fine for vpnc connections via the Network Manager from early April until about 2015-05-27, when this bug started effecting me again:

https://bugs.launchpad.net/ubuntu/+source/network-manager-vpnc/+bug/1459350