GNOME Bugzilla – Bug 707940
More DND fixes / simplifications
Last modified: 2021-07-05 14:41:03 UTC
See patches.
Created attachment 254741 [details] [review] dnd: Use sync_pointer rather than complex enter/leave tracking
Created attachment 254742 [details] [review] dnd: Simplify DND code Instead of tweening the original actor, take a Clone of it and hide the original, meaning that we always own our own actor. This means we can share a lot of the code for destruction a lot better, and we remove a lot complexity relating to snapback and the original position and such.
Created attachment 254743 [details] [review] dnd: Simplify DND code Instead of tweening the original actor, take a Clone of it and hide the original, meaning that we always own our own actor. This means we can share a lot of the code for destruction a lot better, and we remove a lot complexity relating to snapback and the original position and such.
Review of attachment 254741 [details] [review]: OK.
Review of attachment 254743 [details] [review]: Looks good and seems to work fine in testing. ::: js/ui/dnd.js @@ +247,2 @@ + Main.uiGroup.add_actor(this._dragActor); + this._dragActor.raise_top(); Note: This is deprecated (but we have been using it before so ...)
Comment on attachment 254741 [details] [review] dnd: Use sync_pointer rather than complex enter/leave tracking Attachment 254741 [details] pushed as da1e264 - dnd: Use sync_pointer rather than complex enter/leave tracking DND patch has issues dragging app icons. I'll attach a simplified version that tries to do less soon.
Created attachment 254818 [details] [review] dnd: Simplify DND code Instead of tweening the original actor, take a Clone of it and hide the original, meaning that we always own our own actor. This means we can share a lot of the code for destruction a lot better, and we remove a lot complexity relating to snapback and the original position and such.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.