After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707940 - More DND fixes / simplifications
More DND fixes / simplifications
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-11 21:42 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2021-07-05 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dnd: Use sync_pointer rather than complex enter/leave tracking (3.19 KB, patch)
2013-09-11 21:42 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
dnd: Simplify DND code (16.45 KB, patch)
2013-09-11 21:42 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
dnd: Simplify DND code (16.46 KB, patch)
2013-09-11 21:47 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review
dnd: Simplify DND code (13.08 KB, patch)
2013-09-12 21:37 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-09-11 21:42:31 UTC
See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-11 21:42:33 UTC
Created attachment 254741 [details] [review]
dnd: Use sync_pointer rather than complex enter/leave tracking
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-11 21:42:39 UTC
Created attachment 254742 [details] [review]
dnd: Simplify DND code

Instead of tweening the original actor, take a Clone of it and hide the original,
meaning that we always own our own actor. This means we can share a lot of the
code for destruction a lot better, and we remove a lot complexity relating to
snapback and the original position and such.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-11 21:47:42 UTC
Created attachment 254743 [details] [review]
dnd: Simplify DND code

Instead of tweening the original actor, take a Clone of it and hide the
original, meaning that we always own our own actor. This means we can share
a lot of the code for destruction a lot better, and we remove a lot
complexity relating to snapback and the original position and such.
Comment 4 drago01 2013-09-12 06:03:44 UTC
Review of attachment 254741 [details] [review]:

OK.
Comment 5 drago01 2013-09-12 06:06:05 UTC
Review of attachment 254743 [details] [review]:

Looks good and seems to work fine in testing.

::: js/ui/dnd.js
@@ +247,2 @@
+        Main.uiGroup.add_actor(this._dragActor);
+        this._dragActor.raise_top();

Note: This is deprecated (but we have been using it before so ...)
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-09-12 18:34:14 UTC
Comment on attachment 254741 [details] [review]
dnd: Use sync_pointer rather than complex enter/leave tracking

Attachment 254741 [details] pushed as da1e264 - dnd: Use sync_pointer rather than complex enter/leave tracking


DND patch has issues dragging app icons. I'll attach a simplified version that tries to do less soon.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-09-12 21:37:38 UTC
Created attachment 254818 [details] [review]
dnd: Simplify DND code

Instead of tweening the original actor, take a Clone of it and hide the
original, meaning that we always own our own actor. This means we can share
a lot of the code for destruction a lot better, and we remove a lot
complexity relating to snapback and the original position and such.
Comment 8 GNOME Infrastructure Team 2021-07-05 14:41:03 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of  gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/

Thank you for your understanding and your help.