After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707927 - avatar-chooser: allow setting the pixel-size of the button's image
avatar-chooser: allow setting the pixel-size of the button's image
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: tp-aw
3.9.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-11 16:28 UTC by Debarshi Ray
Modified: 2013-09-12 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
avatar-chooser: allow setting the pixel-size of button's image (2.15 KB, patch)
2013-09-11 16:29 UTC, Debarshi Ray 		none Details | Review
avatar-chooser: allow setting the pixel-size of button's image (5.14 KB, patch)
2013-09-12 09:55 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-09-11 16:28:37 UTC 
I have been playing with the Chat designs [1] and want to use TpawAvatarChooser to show the user's own avatar at the left bottom corner. However the avatar chooser shows the image at a hard coded size of 64, whereas we need something slightly smaller for this. Being able to set the size of the image would help.

[1] https://wiki.gnome.org/Design/Apps/Chat
Comment 1 Debarshi Ray 2013-09-11 16:29:17 UTC 
Created attachment 254720 [details] [review]
avatar-chooser: allow setting the pixel-size of button's image
Comment 2 Marco Barisione 2013-09-11 17:08:48 UTC 
I would prefer if you used a property and I'm not sure that “pixel size“ is a great name. Maybe “image size”?
Comment 3 Debarshi Ray 2013-09-12 09:55:47 UTC 
Created attachment 254764 [details] [review]
avatar-chooser: allow setting the pixel-size of button's image
Comment 4 Debarshi Ray 2013-09-12 09:57:33 UTC 
(In reply to comment #2)
> I would prefer if you used a property

Good idea. I turned it into a CONSTRUCT_ONLY property.

> and I'm not sure that “pixel size“ is a
> great name. Maybe “image size”?

I was trying to use the same nomenclature as GtkImage. So, pixel-size is the size in pixels and then in future we can have icon-size which would be a GtkIconSize.
Comment 5 Marco Barisione 2013-09-12 14:35:40 UTC 
Review of attachment 254764 [details] [review]:

It looks good to me.
Comment 6 Debarshi Ray 2013-09-12 16:02:53 UTC 
Comment on attachment 254764 [details] [review]
avatar-chooser: allow setting the pixel-size of button's image

Thanks for the review, Marco!