After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707923 - Right margin hardly visible with some color schemes
Right margin hardly visible with some color schemes
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on: 708583
Blocks:
 
 
Reported: 2013-09-11 15:49 UTC by Phil Wyett
Modified: 2013-10-05 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Hard to see grey line end marker. Indicated by black arrows. (76.49 KB, image/png)
2013-09-11 16:41 UTC, Phil Wyett
Details

Description Phil Wyett 2013-09-11 15:49:17 UTC
Ubuntu Gnome 13.10 as of 2013-08-29. The 80 char end of line marker is virtually impossible to see. This marker should be far more visible.

This is no longer a constant virtical line which was good, but a single line marker. The old way was better. I class this as a regression.
Comment 1 André Klapper 2013-09-11 16:15:56 UTC
Please attach a screenshot. Not sure why this was filed in several places instead of Ubuntu Launchpad.
Comment 2 Phil Wyett 2013-09-11 16:41:56 UTC
Created attachment 254722 [details]
Hard to see grey line end marker. Indicated by black arrows.
Comment 3 Phil Wyett 2013-09-11 16:42:48 UTC
(In reply to comment #1)
> Please attach a screenshot. Not sure why this was filed in several places
> instead of Ubuntu Launchpad.

I was asked to file upstream after reporting the bug on Launchapad and discussion on #ubuntu-gnome IRC channel.
Comment 4 André Klapper 2013-09-11 19:08:00 UTC
Thanks for explaining! Confirming and rephrasing summary to make the conditions to reproduce clearer.
Comment 5 Sébastien Wilmet 2013-09-11 19:12:05 UTC
Some color schemes are affected, but not all. As a temporary workaround you can use the Tango color scheme.

The problem still occurs with GtkSourceView 3.9 (from git).
Comment 6 Sébastien Wilmet 2013-09-22 16:55:45 UTC
Another issue regarding the right margin, the color of the line is not always the same.

Try switching the color schemes: Classic -> Kate vs Cobalt -> Kate.
The Kate margin color is different. It is because the GtkStyleContext is not invalidated when removing and adding a different GtkCssProvider. I've filed bug #708583.
Comment 7 Sébastien Wilmet 2013-09-28 15:04:25 UTC
https://git.gnome.org/browse/gtksourceview/log/?h=wip/fix-right-margin-colors

Testing welcome, I'm not a designer and perhaps my screen doesn't render the true colors.
Comment 8 Sébastien Wilmet 2013-10-05 14:34:55 UTC
The commit is pushed to the master branch. If you like the new styles, the commit can be backported to the gnome-3-10 branch too.