After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707922 - notebook tab style improvements
notebook tab style improvements
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-11 15:47 UTC by William Jon McCann
Modified: 2014-01-09 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove tab engine code (6.16 KB, patch)
2013-09-11 15:47 UTC, William Jon McCann
none Details | Review
Update the style of GtkNotebook tabs (6.25 KB, patch)
2013-09-11 15:47 UTC, William Jon McCann
none Details | Review
Remove custom arrow from engine (2.30 KB, patch)
2013-09-11 15:47 UTC, William Jon McCann
none Details | Review
Remove tab engine code (6.16 KB, patch)
2013-10-01 19:52 UTC, William Jon McCann
committed Details | Review
Update the style of GtkNotebook tabs (6.49 KB, patch)
2013-10-01 19:52 UTC, William Jon McCann
committed Details | Review
Don't draw tab gap (852 bytes, patch)
2013-10-01 19:52 UTC, William Jon McCann
committed Details | Review
Don't inset toolbars (4.31 KB, patch)
2013-10-01 19:52 UTC, William Jon McCann
committed Details | Review
Remove custom arrow from engine (2.30 KB, patch)
2013-10-01 19:52 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2013-09-11 15:47:18 UTC
We've been discussing and iterating for months if not years on various ways to
improve the style of our notebook tabs. Over the course of the summer we
converged on an approach that makes the tabs less visually prominent.
Comment 1 William Jon McCann 2013-09-11 15:47:47 UTC
Created attachment 254705 [details] [review]
Remove tab engine code
Comment 2 William Jon McCann 2013-09-11 15:47:50 UTC
Created attachment 254706 [details] [review]
Update the style of GtkNotebook tabs

This changes the style to be less visually prominent, a bit flatter,
and hopefully more elegant.
Comment 3 William Jon McCann 2013-09-11 15:47:53 UTC
Created attachment 254707 [details] [review]
Remove custom arrow from engine

It is now the default in GTK.
Comment 4 William Jon McCann 2013-10-01 19:52:20 UTC
Created attachment 256214 [details] [review]
Remove tab engine code
Comment 5 William Jon McCann 2013-10-01 19:52:27 UTC
Created attachment 256215 [details] [review]
Update the style of GtkNotebook tabs

This changes the style to be less visually prominent, a bit flatter,
and hopefully more elegant.
Comment 6 William Jon McCann 2013-10-01 19:52:31 UTC
Created attachment 256216 [details] [review]
Don't draw tab gap

Tell GTK+ that we don't require a gap at the bottom of the active
tab.
Comment 7 William Jon McCann 2013-10-01 19:52:39 UTC
Created attachment 256217 [details] [review]
Don't inset toolbars

Now that we're using inset tab bars the inset toolbars don't fit
in very well.
Comment 8 William Jon McCann 2013-10-01 19:52:43 UTC
Created attachment 256218 [details] [review]
Remove custom arrow from engine

It is now the default in GTK.
Comment 9 William Jon McCann 2013-10-02 15:16:36 UTC
Attachment 256214 [details] pushed as f350bb9 - Remove tab engine code
Attachment 256215 [details] pushed as 2ad35ff - Update the style of GtkNotebook tabs
Attachment 256216 [details] pushed as ea3786a - Don't draw tab gap
Attachment 256217 [details] pushed as fa9b443 - Don't inset toolbars
Attachment 256218 [details] pushed as 7721a23 - Remove custom arrow from engine
Comment 10 Jakub Steiner 2014-01-09 14:29:37 UTC
One last thing that would truly improve the aesthetics and usability is the ability to style :hover state for notebook tabs. (bug #711233)

Prelighting the tab and only drawing the close button for unselected tabs is impossible right now.
Comment 11 Ignacio Casal Quinteiro (nacho) 2014-01-09 14:34:13 UTC
TBH I wouldn't like to not have the close buttons on the not focused tabs, since lots of times I close tabs by clicking on the icons of the tabs that are not focused and I think this is done by a lot of people and also in other apps like the browsers.
Comment 12 Jakub Steiner 2014-01-09 22:53:15 UTC
I'm a proponent of that too, but there is a strong resistance :) Prelighting the close button itself would help to avoid closing my mistake too.
Comment 13 William Jon McCann 2014-01-09 22:58:56 UTC
Might be better for further improvements and discussion to be done in new bugs.