After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707919 - display: add support for more cursor types
display: add support for more cursor types
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
wayland 3.10
Depends on:
Blocks:
 
 
Reported: 2013-09-11 15:35 UTC by Giovanni Campagna
Modified: 2013-09-12 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display: add support for more cursor types (4.33 KB, patch)
2013-09-11 15:35 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-11 15:35:37 UTC 
Necessary to remove the same code from gnome-shell
Comment 1 Giovanni Campagna 2013-09-11 15:35:40 UTC 
Created attachment 254698 [details] [review]
display: add support for more cursor types

These cursors are used by gnome-shell, supporting them allows
to reduce GDK usage in the shell.

Also, make meta_screen_set_cursor() public.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-11 18:35:37 UTC 
Review of attachment 254698 [details] [review]:

::: src/core/display.c
@@ +4007,3 @@
+
+  if (glyph < XC_num_glyphs)
+    xcursor = XCreateFontCursor (display->xdisplay, glyph);

if (name)
  ...
else
  ...

is more clear IMO.
Comment 3 Giovanni Campagna 2013-09-12 08:17:27 UTC 
Pushed with suggested change.
Attachment 254698 [details] pushed as 9def559 - display: add support for more cursor types