After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707916 - Google CardDAV access is broken
Google CardDAV access is broken
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-11 15:11 UTC by Patrick Ohly
Modified: 2013-09-12 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add CardDAV OAuth2 scope (1.70 KB, patch)
2013-09-11 15:11 UTC, Patrick Ohly
needs-work Details | Review
google: Add the OAuth2 scope for CardDAV (1.76 KB, patch)
2013-09-12 13:09 UTC, Debarshi Ray
committed Details | Review

Description Patrick Ohly 2013-09-11 15:11:23 UTC
Created attachment 254694 [details] [review]
add CardDAV OAuth2 scope

From the patch:

-----------------
Google tracks access to contacts via CardDAV and GData with different
OAuth2 tokens; for calendar, the token is the same in both
protocols. This does not affect Evolution, because Evolution only
uses GData (so far), but GOA claims to support CardDAV access to Google
and thus should ask for the right scope.

That the old set of scopes was not enough was verified by adding
support for GOA to SyncEvolution. Without this patch, Google rejects
access to the CardDAV resources with a 401 "AuthSub challenge".
------------------

The patch was prepared tested with the latest GOA 3.8.x, but should equally apply to the current development version.

Note that I have not pushed that SyncEvolution patch to a public repo. I'm still working on the instructions for users, for which I need to know whether GOA 3.10 will fix this problem :-)
Comment 1 Debarshi Ray 2013-09-12 13:08:28 UTC
Review of attachment 254694 [details] [review]:

The credentials generation should also be bumped, because the old access tokens will not work with the new set of scopes.

::: src/goabackend/goagoogleprovider.c
@@ +124,3 @@
 
+         /* Google Contacts API (CardDAV) */
+         "https://www.googleapis.com/auth/carddav "

Probably better to mention that this is undocumented. I keep getting lost in all the details about all the providers and Google is particularly confusing.
Comment 2 Debarshi Ray 2013-09-12 13:09:24 UTC
Created attachment 254781 [details] [review]
google: Add the OAuth2 scope for CardDAV
Comment 3 Debarshi Ray 2013-09-12 13:17:46 UTC
Comment on attachment 254781 [details] [review]
google: Add the OAuth2 scope for CardDAV

Pushed to both master and gnome-3-10.