GNOME Bugzilla – Bug 707906
network: Remove a spurious signal handler
Last modified: 2013-09-12 16:41:45 UTC
I'm not sure if this fixes https://bugzilla.redhat.com/show_bug.cgi?id=990196 since I can't reproduce that crash but connecting the same handler to the same widget and signal twice seems wrong anyway.
Created attachment 254671 [details] [review] network: Remove a spurious signal handler
Review of attachment 254671 [details] [review]: Doubt it would fix the crash, but otherwise looks good to me.
Created attachment 254686 [details] [review] network: Fix a possible crash with no active connections As a precaution, check the return value of get_active_connections to avoid dereferencing a NULL pointer. https://bugzilla.redhat.com/show_bug.cgi?id=990196
Created attachment 254687 [details] [review] network: Fix a possible crash with no active connections As a precaution, check the return value of get_active_connections to avoid dereferencing a NULL pointer. https://bugzilla.redhat.com/show_bug.cgi?id=990196
Review of attachment 254687 [details] [review]: Ah yes, it looks like this call's return value is checked like this elsewhere except in these places. Please push to master and gnome-3-8
Attachment 254671 [details] pushed as aee3f9d - network: Remove a spurious signal handler
Review of attachment 254671 [details] [review]: In the future, you should mention the consequence of the patch in the commit subject, and how and why in the body. Why was it "spurious" anyway?
(In reply to comment #7) > Review of attachment 254671 [details] [review]: > > In the future, you should mention the consequence of the patch in the commit > subject, and how and why in the body. > > Why was it "spurious" anyway? Yes, sorry. It's quite obvious when looking at the surrounding code, that's why I didn't write anything further - it connects the same handler to the same widget and signal twice.
So, not spurious, but duplicated :)