Created attachment 254586 [details] [review]
util: fix warnings when compiling gnome-shell-wayland

Replace our version of the gettext macros with those in glib,
so that they don't conflict with gnome-shell.

Created attachment 254587 [details] [review]
wayland: fix deprecation warnings

Replace the deprecated APIs with the modern variants (which
also give us full control on the versioning).
Also, note that we only support version 2 of wl_seat. Version
3 is for multiple pointer/keyboards for a client, but
we don't implement that yet. If a client requests version 3
of wl_seat or make a version 3 request, it will get a protocol error.

Created attachment 254588 [details] [review]
wayland: fix interface versioning

Add MIN(...) with the interface version actually implemented
to all resource constructor, so that we never risk seeing requests
we don't implement (and consequently segfault)

Created attachment 254589 [details] [review]
wayland: use symbolic constants for interface version

Replace magic numbers scattered around the code with proper
macros collected in one header file.

Review of attachment 254586 [details] [review]:

OK.

Review of attachment 254587 [details] [review]:

Looks good.

Review of attachment 254588 [details] [review]:

OK.

Review of attachment 254589 [details] [review]:

LGTM.

Attachment 254586 [details] pushed as 72b6699 - util: fix warnings when compiling gnome-shell-wayland
Attachment 254587 [details] pushed as 95a9655 - wayland: fix deprecation warnings
Attachment 254588 [details] pushed as 73ee491 - wayland: fix interface versioning
Attachment 254589 [details] pushed as 168ea64 - wayland: use symbolic constants for interface version