GNOME Bugzilla – Bug 707847
Mark non-translatable images as such
Last modified: 2014-02-21 23:10:55 UTC
On https://l10n.gnome.org/module/gnome-user-docs/gnome-help/master/hu/images/ there is a lot of images listed as translatable, but they do not contain any translatable strings. It would be better to not mark these as translatable, so that the image list pages in d-l would be cleaner.
Created attachment 254585 [details] [review] Mark images as not translatable - first batch First batch. There are more such images, but to remove those string changes are necessary, which I'd avoid this close to release. This group should generate only string removals in translations, I'll submit the rest later.
Review of attachment 254585 [details] [review]: Pushed, thanks!
The patch submitted was pushed to master in 3463627a4e9ca2193592af65e27e34f8965fd167. Available at: https://git.gnome.org/browse/gnome-user-docs/commit/?id=3463627a4e9ca2193592af65e27e34f8965fd167 Closing bug as RESOLVED and FIXED.
As Gabor said, those were not all the images so this bug is not resolved yet.
I didn't notice that. My bad. Thanks for re-opening. Marking status as NEW.
xmlns:its="http://www.w3.org/2005/11/its" and <media its:translate="no"> could also be applied on all occurrences of: * gnome.png * yelp-icon-big.png * go-down.png * view-fullscreen-16.png * keyboard-key-menu.svg * input-keyboard-symbolic.png * system-run-symbolic.svg * emblem-system-symbolic.svg * view-more-symbolic.svg * shell-message-tray.png
I've fixed all of them now. I hope.
Hi André Thanks for helping out. I still see some problems: - you skipped the instances of go-down.png - when marking the rest as not translatable, you forgot to restore the translatability of their accessible text. So for example here: <media its:translate="no" type="image" src="figures/view-fullscreen-16.png">fullscreen</media> the translate=no applies to the "fullscreen" word, which does not appear on screen, but Orca reads it for those who can't see the icon. Therefore, we need to wrap that word like this: <span its:translate="yes">fullscreen</span>
Created attachment 269162 [details] [review] Fix the remaining issues I hope this is all we need but please review, it's early ;)
Review of attachment 269162 [details] [review]: Committed to trunk. To gnome-3-10 I only committed the parts that make the accessible texts translatable, and skipped the go-down.png issue - way too much work before 3.10.3 for almost no gain.
Finally... thanks for the support everyone :).