After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707806 - altTab: Only create one settings instance per window switcher popup
altTab: Only create one settings instance per window switcher popup
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-09 21:05 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-09-10 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
altTab: Only create one settings instance per window switcher popup (3.19 KB, patch)
2013-09-09 21:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-09-09 21:05:34 UTC 
Every settings instance we create is a round-trip to the dconf
daemon, so we need to be careful of not creating them too haphazardly.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-09 21:05:36 UTC 
Created attachment 254520 [details] [review]
altTab: Only create one settings instance per window switcher popup
Comment 2 Giovanni Campagna 2013-09-10 07:37:43 UTC 
Review of attachment 254520 [details] [review]:

Good idea. Although maybe it makes sense to share them globally, as the window switcher is used often and is created/destroyed often (or maybe we could avoid destroying it?)
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-10 14:23:56 UTC 
Attachment 254520 [details] pushed as 1edb9f7 - altTab: Only create one settings instance per window switcher popup