After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707774 - ClutterClickAction can trigger a crash if disposes at inappropriate time
ClutterClickAction can trigger a crash if disposes at inappropriate time
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
1.15.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-09 15:10 UTC by Lionel Landwerlin
Modified: 2013-09-10 20:53 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
click-action: disconnect signals and gsources on dispose (1.75 KB, patch)
2013-09-09 15:10 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-09-09 15:10:01 UTC 
If the ClutterClickAction is disposed before the timeout callback is called or before the capture-event signal is disconnect, you end up with a crash.
Better cleanup all this in the dispose().
Comment 1 Lionel Landwerlin 2013-09-09 15:10:40 UTC 
Created attachment 254493 [details] [review]
click-action: disconnect signals and gsources on dispose
Comment 2 Matthias Clasen 2013-09-10 19:56:37 UTC 
looks like a pretty obvious crash fix - we should probably get this into 3.10 ?
Comment 3 Emmanuele Bassi (:ebassi) 2013-09-10 20:47:02 UTC 
Review of attachment 254493 [details] [review]:

yes, this looks okay.
Comment 4 Lionel Landwerlin 2013-09-10 20:53:22 UTC 
Pushed to 1.16