After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707734 - rtp: add payloader and depayloader for 24bit raw audio
rtp: add payloader and depayloader for 24bit raw audio
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-08 18:23 UTC by David Holroyd
Modified: 2013-09-18 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add rtpL24depay / rtpL24pay elements (23.17 KB, patch)
2013-09-08 18:25 UTC, David Holroyd
none Details | Review

Description David Holroyd 2013-09-08 18:23:43 UTC
I don't think GStreamer currently supports this, so I copied and modified the elements supporting 16 bit raw audio in order to support 24 bit payloads.
Comment 1 David Holroyd 2013-09-08 18:25:02 UTC
Created attachment 254430 [details] [review]
Add rtpL24depay / rtpL24pay elements
Comment 2 Wim Taymans 2013-09-09 09:09:08 UTC
This is part of RFC 3190, which also lists DAT12 and L20 as extensions. I'm just considering if we need an ARAW de/payloader that handles all these raw formats or keep on duplicating the audio de/payloaders. It would make for less code but then there would not be a direct mapping between the encoding-name and the payloader anymore.

For now, let's just duplicate it to keep things consistent.
Comment 3 David Holroyd 2013-09-09 10:30:42 UTC
Would,
 - renaming these elements to something more generic (rtparawpay / rtparawdepay?)
 - requiring that a 'sample format' be specified (but initially only allow the value S24BE)
 - otherwise keeping the code the same

make for an easier transition to one-element-for-all-formats, or just be too confusing?

I don't mind doing some basic rearrangement if it makes the code more useful -- bearing in mind that I am new to gstreamer and glib APIs!
Comment 4 Wim Taymans 2013-09-09 13:16:22 UTC
commit a956a6ceb2deb87cc1361aee1d6626449f46dab2
Author: David Holroyd <dave@badgers-in-foil.co.uk>
Date:   Mon Sep 9 11:16:40 2013 +0200

    rtp: add L24 pay and depayloader
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=707734
Comment 5 Wim Taymans 2013-09-09 13:18:05 UTC
(In reply to comment #3)
> Would,
>  - renaming these elements to something more generic (rtparawpay /
> rtparawdepay?)
>  - requiring that a 'sample format' be specified (but initially only allow the
> value S24BE)
>  - otherwise keeping the code the same

I think it's a bit confusing for now.