After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707705 - Remove empty functions that just chain up to the parent
Remove empty functions that just chain up to the parent
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-08 00:18 UTC by Kalev Lember
Modified: 2013-09-08 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
datetime: Remove empty constructor function (1.67 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
a11y-settings: Remove empty constructor and dispose functions (2.23 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
clipboard: Remove empty constructor function (1.79 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
media-keys: Remove empty constructor function (1.80 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
mouse: Remove empty constructor and dispose functions (1.94 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
orientation: Remove empty constructor and dispose functions (2.12 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
print-notifications: Remove empty constructor function (2.16 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
rfkill: Remove empty constructor function (1.76 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
sound: Remove empty constructor function (1.62 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
updates: Remove empty constructor function (1.74 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
wacom: Remove empty constructor and dispose functions (1.96 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review
xsettings: Remove empty constructor function (1.84 KB, patch)
2013-09-08 00:19 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2013-09-08 00:18:13 UTC 
A number of g-s-d plugins have copy-paste code where constructor and dispose do nothing but chain up to the parent class.
Comment 1 Kalev Lember 2013-09-08 00:19:14 UTC 
Created attachment 254369 [details] [review]
datetime: Remove empty constructor function

It was just chaining up.
Comment 2 Kalev Lember 2013-09-08 00:19:17 UTC 
Created attachment 254370 [details] [review]
a11y-settings: Remove empty constructor and dispose functions

These were just chaining up.
Comment 3 Kalev Lember 2013-09-08 00:19:21 UTC 
Created attachment 254371 [details] [review]
clipboard: Remove empty constructor function

It was just chaining up.
Comment 4 Kalev Lember 2013-09-08 00:19:24 UTC 
Created attachment 254372 [details] [review]
media-keys: Remove empty constructor function

It was just chaining up.
Comment 5 Kalev Lember 2013-09-08 00:19:28 UTC 
Created attachment 254373 [details] [review]
mouse: Remove empty constructor and dispose functions

These were just chaining up.
Comment 6 Kalev Lember 2013-09-08 00:19:31 UTC 
Created attachment 254374 [details] [review]
orientation: Remove empty constructor and dispose functions

These were just chaining up.
Comment 7 Kalev Lember 2013-09-08 00:19:34 UTC 
Created attachment 254375 [details] [review]
print-notifications: Remove empty constructor function

It was just chaining up.
Comment 8 Kalev Lember 2013-09-08 00:19:37 UTC 
Created attachment 254376 [details] [review]
rfkill: Remove empty constructor function

It was just chaining up.
Comment 9 Kalev Lember 2013-09-08 00:19:42 UTC 
Created attachment 254377 [details] [review]
sound: Remove empty constructor function

It was just chaining up.
Comment 10 Kalev Lember 2013-09-08 00:19:45 UTC 
Created attachment 254378 [details] [review]
updates: Remove empty constructor function

It was just chaining up.
Comment 11 Kalev Lember 2013-09-08 00:19:49 UTC 
Created attachment 254379 [details] [review]
wacom: Remove empty constructor and dispose functions

These were just chaining up.
Comment 12 Kalev Lember 2013-09-08 00:19:53 UTC 
Created attachment 254380 [details] [review]
xsettings: Remove empty constructor function

It was just chaining up.
Comment 13 Rui Matos 2013-09-08 15:58:24 UTC 
Kill them with fire!

I'm not going to mark everything a-c-n individually but they all look fine.
Comment 14 Kalev Lember 2013-09-08 16:08:03 UTC 
Thanks!

Attachment 254369 [details] pushed as b04239d - datetime: Remove empty constructor function
Attachment 254370 [details] pushed as c6ad66f - a11y-settings: Remove empty constructor and dispose functions
Attachment 254371 [details] pushed as 48242d3 - clipboard: Remove empty constructor function
Attachment 254372 [details] pushed as 93c12c2 - media-keys: Remove empty constructor function
Attachment 254373 [details] pushed as 98df447 - mouse: Remove empty constructor and dispose functions
Attachment 254374 [details] pushed as 3b6e655 - orientation: Remove empty constructor and dispose functions
Attachment 254375 [details] pushed as a4d85f9 - print-notifications: Remove empty constructor function
Attachment 254376 [details] pushed as 10c0778 - rfkill: Remove empty constructor function
Attachment 254377 [details] pushed as c2b32ad - sound: Remove empty constructor function
Attachment 254378 [details] pushed as d41dd92 - updates: Remove empty constructor function
Attachment 254379 [details] pushed as 47b7e09 - wacom: Remove empty constructor and dispose functions
Attachment 254380 [details] pushed as b8b9cff - xsettings: Remove empty constructor function