After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707671 - with Show Desktop Icons enabled, icons are not faded to/from Activities Overview
with Show Desktop Icons enabled, icons are not faded to/from Activities Overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: background
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-07 04:55 UTC by Derek Moore
Modified: 2013-11-14 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overview: Fix stacking of background and desktop icons (1.74 KB, patch)
2013-11-14 15:38 UTC, Florian Müllner
committed Details | Review

Description Derek Moore 2013-09-07 04:55:57 UTC
GNOME Shell dramatically fades so many other windows in so many different ways, why can't it fade the root window controlled by Nautilus / Files?

If you want the icons to be disappeared entirely, can't you fade Files' root window to fully transparent while you fade to blackened a root root window of  the background image?
Comment 1 Florian Müllner 2013-11-14 15:38:40 UTC
Created attachment 259816 [details] [review]
overview: Fix stacking of background and desktop icons

(In reply to comment #0)
> GNOME Shell dramatically fades so many other windows in so many different ways,
> why can't it fade the root window controlled by Nautilus / Files?

It is called a bug. The code to fade desktop icons has existed for a long time, but it was broken at some point by (seemingly) unrelated changes.


If desktop icons are enabled and not covered by maximized windows,
we will fade them in/out during overview transitions. However when
moving background handling into mutter/gnome-shell, we ended up with
the overview background on top of the DESKTOP window clone, hiding
the fade transition.
Fix the stack order to bring the effect back.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-11-14 15:41:07 UTC
Review of attachment 259816 [details] [review]:

OK.
Comment 3 Florian Müllner 2013-11-14 15:51:35 UTC
Attachment 259816 [details] pushed as 175c5d9 - overview: Fix stacking of background and desktop icons
Comment 4 Derek Moore 2013-11-14 16:03:47 UTC
I tried to dig my way through the code on this one, but I wasn't able to figure it out. Very cool simple fix! Nice work!