Created attachment 254325 [details] [review]
Magnifier: Remove unused functions

Review of attachment 254325 [details] [review]:

Some of them are used for the dbus interface.

Regarding the commit message please add a full link to the bug and not just "Bug 707666"

::: js/ui/magnifier.js
@@ -316,3 @@
-     * @return: The color as a string, e.g. '#0000ffff' or 'blue'.
-     */
-    getCrosshairsColor: function() {

Is used https://git.gnome.org/browse/gnome-shell/tree/js/ui/magnifierDBus.js#n323

@@ -342,3 @@
-     *          crosshairs.
-     */
-    getCrosshairsThickness: function() {

Is used https://git.gnome.org/browse/gnome-shell/tree/js/ui/magnifierDBus.js#n269

@@ -386,3 @@
-     *          crosshairs.
-     */
-    getCrosshairsLength: function() {

https://git.gnome.org/browse/gnome-shell/tree/js/ui/magnifierDBus.js#n287

@@ -416,3 @@
-     * @return:   Whether the crosshairs are clipped.
-     */
-     getCrosshairsClip: function() {

https://git.gnome.org/browse/gnome-shell/tree/js/ui/magnifierDBus.js#n305

@@ -1582,3 @@
-     * @color:  The color as a Clutter.Color.
-     */
-    getColor: function() {

Used in getCrosshairsColor

@@ -1605,3 @@
-     */
-    getThickness: function() {
-        return this._horizLeftHair.get_height();

Used in getCrosshairsThickness

@@ -1654,3 @@
-     * @return: The length of the crosshairs.
-     */
-    getLength: function() {

Used in getCrosshairsLength

Created attachment 254337 [details] [review]
Magnifier: Remove unused functions

Review of attachment 254337 [details] [review]:

OK.

Review of attachment 254337 [details] [review]:

commit c9d6b13f6ac691d678163d72dde7b8664d588d18
Author: Magdalen Berns <thisMagpie@live.com>
Date:   Sat Sep 7 11:43:29 2013 +0100

    Remove unused functions
    
    Bug https://bugzilla.gnome.org/show_bug.cgi?id=707666