After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707663 - Ignore window visibility when sorting apps
Ignore window visibility when sorting apps
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 700133 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-06 22:09 UTC by Florian Müllner
Modified: 2013-09-07 01:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Stop using window visibility when comparing apps (2.05 KB, patch)
2013-09-06 22:09 UTC, Florian Müllner 		committed Details | Review
app: Removed unused function (1.06 KB, patch)
2013-09-06 22:09 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-09-06 22:09:28 UTC 
Auto-minimization of fullscreen windows messes up the app switcher:

  (1) run three applications (A), (B) and (C)
  (2) focus (A)
  (3) focus (B), fullscreen it
  (4) <super>tab to (A)
  (5) <super>tab again - (C) is focused instead of (B)

We already stopped putting minimized windows at the end of the window list in bug 693991, we should do the same for apps ...
Comment 1 Florian Müllner 2013-09-06 22:09:33 UTC 
Created attachment 254315 [details] [review]
app: Stop using window visibility when comparing apps

shell_app_compare() (which is only used as sort function for
shell_app_system_get_running() nowadays) currently takes the
visibility of an app's windows into account, e.g. applications
with visible windows (non-minimized windows on current workspace)
sort earlier than applications without.
This translate traditional window-switcher behavior to applications,
but we stopped sorting by workspace in the app-switcher a while ago,
and with the new auto-minimization behavior of fullscreen windows
it is more confusing than helpful - in fact, since mutter commit
7e61ef09369a we no longer do this for the window list, so it
makes sense to apply the same to application sorting.
Comment 2 Florian Müllner 2013-09-06 22:09:38 UTC 
Created attachment 254316 [details] [review]
app: Removed unused function
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-06 22:22:34 UTC 
Review of attachment 254316 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-09-06 22:23:17 UTC 
Review of attachment 254315 [details] [review]:

Ah, this explains it. I always use the window switcher.
Comment 5 Florian Müllner 2013-09-06 22:26:45 UTC 
Attachment 254315 [details] pushed as 1dfc38d - app: Stop using window visibility when comparing apps
Attachment 254316 [details] pushed as b437e68 - app: Removed unused function

> Ah, this explains it. I always use the window switcher.

I figured :-)
Comment 6 Florian Müllner 2013-09-07 01:45:35 UTC 
*** Bug 700133 has been marked as a duplicate of this bug. ***