After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707660 - playbin, playsink: typo in convert-sample signal docs
playbin, playsink: typo in convert-sample signal docs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal trivial
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-06 21:23 UTC by Loïc Minier
Modified: 2013-09-18 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-playbin-Fix-doc-of-convert-sample-signal.patch (1.15 KB, patch)
2013-09-06 21:24 UTC, Loïc Minier 		committed Details | Review
0002-playsink-Fix-doc-of-convert-sample-signal.patch (1.19 KB, patch)
2013-09-06 21:25 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2013-09-06 21:23:56 UTC 
Hi

while switching from convert-frame to convert-signal and from GstBuffer to GstSample, it seems a couple of inline weren't updated.

Attaching a couple of trivial patches for this.

Cheers,
Comment 1 Loïc Minier 2013-09-06 21:24:37 UTC 
Created attachment 254309 [details] [review]
0001-playbin-Fix-doc-of-convert-sample-signal.patch
Comment 2 Loïc Minier 2013-09-06 21:25:06 UTC 
Created attachment 254310 [details] [review]
0002-playsink-Fix-doc-of-convert-sample-signal.patch
Comment 3 Tim-Philipp Müller 2013-09-07 14:02:07 UTC 
Thanks, pushed (squashed):


commit 8492b956cd3ce23eb38bf78d3aaaeafbcc125e2e
Author: Loïc Minier <lool@dooz.org>
Date:   Fri Sep 6 23:17:44 2013 +0200

    playback: fix docs of convert-sample action signal
    
    convert-sample returns a GstSample, not a GstBuffer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=707660