Created attachment 254217 [details] [review]
glib/tests/gdatetime: Add test for the C locale

This should work, but fails.

Either GDateTime's format needs to work with UTF-8 characters in an ASCII encoding locale, or it needs to emit a warning (and docs to be updated to mention this possible failure case).

*** Bug 698952 has been marked as a duplicate of this bug. ***

Review of attachment 254217 [details] [review]:

Otherwise, looks reasonable, although I'm not sure what (if any) guarnatees we can make for running in the C locale.

::: glib/tests/gdatetime.c
@@ +913,3 @@
+  if (strstr (setlocale (LC_ALL, NULL), "C") == NULL)
+    {
+      g_test_message ("locale ja_JP.eucjp not available, skipping non-UTF8 tests");

Copy-paste error in the message

Review of attachment 254217 [details] [review]:

Otherwise, looks reasonable, although I'm not sure what (if any) guarantees we can make for running in the C locale.

::: glib/tests/gdatetime.c
@@ +913,3 @@
+  if (strstr (setlocale (LC_ALL, NULL), "C") == NULL)
+    {
+      g_test_message ("locale ja_JP.eucjp not available, skipping non-UTF8 tests");

Copy-paste error in the message

Created attachment 353667 [details] [review]
glib/tests/gdatetime: Add test for the C locale

This should work, but fails.

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/755.