After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707508 - st: Make StScrollViewFade a ClutterShaderEffect
st: Make StScrollViewFade a ClutterShaderEffect
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-04 20:34 UTC by Florian Müllner
Modified: 2013-09-04 21:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st: Make StScrollViewFade a ClutterShaderEffect (14.28 KB, patch)
2013-09-04 20:34 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-09-04 20:34:11 UTC 
While working on bug 707409, I came up with this cleanup. Tested on hardware with and without GLSL support, and the result is as expected in both cases (working effect in the former, no console spam in the latter).
Comment 1 Florian Müllner 2013-09-04 20:34:15 UTC 
Created attachment 254126 [details] [review]
st: Make StScrollViewFade a ClutterShaderEffect

The cogl_shader_XXX and cogl_program_YYY APIs have been deprecated
this cycle, so port to ClutterShaderEffect instead.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-04 20:46:13 UTC 
Review of attachment 254126 [details] [review]:

OK.
Comment 3 Florian Müllner 2013-09-04 21:14:27 UTC 
Attachment 254126 [details] pushed as b403845 - st: Make StScrollViewFade a ClutterShaderEffect