GNOME Bugzilla – Bug 707474
Extend MetaCursorTracker with stuff
Last modified: 2013-09-09 16:05:01 UTC
Asked by Jasper reviewing the wip/wayland branch of gnome-shell. First patches are for master, then for wayland.
Created attachment 254097 [details] [review] MetaCursorTracker: extend with query pointer abilities We need an abstraction in gnome-shell for XQueryPointer, and MetaCursorTracker seems a good place for it.
Created attachment 254098 [details] [review] MetaCursorTracker: add methods for setting the cursor visibility clutter_stage_show_cursor()/hide_cursor() only works in the X11 backend (where someone else is in charge of showing the cursor), and even then, it has confusing effects when running nested wayland, so an abstraction layer is needed.
Review of attachment 254097 [details] [review]: OK. ::: src/core/meta-cursor-tracker.c @@ +27,3 @@ + * @short_description: Mutter cursor tracking helper. Originally only + * tracking the cursor image, now more of a "core + * pointer abstraction" Hey now. I thought you said you would also capture those "cursor moved" events in XI2.4 or whatever here to replace PointerWatcher. (I'd remove the "Originally only" part. Seems a bit superfluous for somebody looking at the gtk-doc)
Review of attachment 254098 [details] [review]: You might want to double-check this one, kiddo. :) ::: src/core/meta-cursor-tracker.c @@ +306,3 @@ + tracker->screen->xroot); + else + XFixesShowCursor (tracker->screen->display->xdisplay, You might want to double-check this one, kiddo.
Created attachment 254104 [details] [review] MetaCursorTracker: extend with query pointer abilities (wayland side) We need an abstraction in gnome-shell for XQueryPointer, and MetaCursorTracker seems a good place for it.
Created attachment 254105 [details] [review] MetaCursorTracker: add methods for setting the cursor visibility (wayland side) clutter_stage_show_cursor()/hide_cursor() only works in the X11 backend (where someone else is in charge of showing the cursor), and even then, it has confusing effects when running nested wayland, so an abstraction layer is needed.
Review of attachment 254105 [details] [review]: OK.
Review of attachment 254104 [details] [review]: Looks good.
Attachment 254097 [details] pushed as 3053cc0 - MetaCursorTracker: extend with query pointer abilities Attachment 254098 [details] pushed as 6327b8d - MetaCursorTracker: add methods for setting the cursor visibility Let's get the easy stuff out first.
git-bz bah...