GNOME Bugzilla – Bug 707437
Miscellaneous string fixes
Last modified: 2013-09-29 03:24:11 UTC
Here are a few patches for some string issues I spotted when doing the British English translation. Hopefully they can be applied as soon as gnome-maps branches for 3.10, otherwise they’ll bit-rot pretty fast.
Created attachment 254037 [details] [review] strings: Use Unicode quotation marks and apostrophes Also add a missing full stop in the appdata file. Helps:
Created attachment 254038 [details] [review] data: Edit strings for clarity Minor changes. Helps:
Created attachment 254039 [details] [review] app: Add translator comments for the application name It’s not clear whether ‘Maps’ refers to the application name or to the plural of a map. Closes:
Also, the following string needs a translator comment: #: ../src/userLocation.js:58 #, c-format msgid "" "%s\n" "Position Accuracy: %s" msgstr "" "%s\n" "Position Accuracy: %s" since it’s not clear what the first (and possibly also the second) parameter means. I can’t easily tell from the code either.
Review of attachment 254037 [details] [review]: What do you mean by unicode quotation marks and apostrophes? Aren't they the same as ASCII ones? ::: data/gnome-maps.appdata.xml.in @@ -6,3 @@ <description> <_p>Maps gives you quick access to maps all across the world. It allows you - to quickly find the place you're looking for by searching for a city or undefined
Review of attachment 254038 [details] [review]: ack
Review of attachment 254039 [details] [review]: ack
Review of attachment 254039 [details] [review]: This one can go already actually.
Created attachment 254083 [details] [review] MapLocation: Make two forgotten strings for translation These strings were not marked for translation by accident.
Created attachment 254084 [details] [review] UserLocation: Add a translator commit
Comment on attachment 254039 [details] [review] app: Add translator comments for the application name commit 27f8436d8591d02feba957fe349a221a881a5d59 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Tue Sep 3 22:29:53 2013 -0600 app: Add translator comments for the application name It’s not clear whether ‘Maps’ refers to the application name or to the plural of a map. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=707437 src/application.js | 1 + src/mainWindow.js | 1 + 2 files changed, 2 insertions(+)
(In reply to comment #5) > Review of attachment 254037 [details] [review]: > > What do you mean by unicode quotation marks and apostrophes? Aren't they the > same as ASCII ones? They’re different: Unicode quotation marks are curly and easier to read: For example: • ‘Unicode’ “quotation marks” • 'ASCII' "quotation marks" (Although this really should be viewed in a non-monospace font to be realistic.) A Unicode apostrophe is just a single right-quotation-mark.
Review of attachment 254083 [details] [review]: These need translation comments as well. *What* is unknown? *What* is exact? :-)
Review of attachment 254084 [details] [review]: That looks like a good comment to me.
(In reply to comment #9) > Created an attachment (id=254083) [details] [review] > MapLocation: Make two forgotten strings for translation > > These strings were not marked for translation by accident. Could you please commit this patch already? It's not a string freeze break, and it's quite important.
Comment on attachment 254083 [details] [review] MapLocation: Make two forgotten strings for translation Attachment 254083 [details] pushed as e83e1c1 - MapLocation: Make two forgotten strings for translation
Created attachment 254186 [details] [review] UserLocation,MapLocation: Add translator comments How about these now?
Review of attachment 254186 [details] [review]: Looks good to me. :-)
Attachment 254186 [details] pushed as 6962989 - UserLocation,MapLocation: Add translator comments
Review of attachment 254037 [details] [review]: Sorry, it seems like a font-specific thing (or it should be) since they really are essentially the same. It feels just wrong to use a different unicode for exactly the same character just to render it nicely. :) Besides it makes it difficult to type.
(In reply to comment #21) > Sorry, it seems like a font-specific thing (or it should be) since they really > are essentially the same. It feels just wrong to use a different unicode for > exactly the same character just to render it nicely. :) Please read this and reconsider: http://practicaltypography.com/straight-and-curly-quotes.html. The difference between straight and curly quotation marks is not especially subtle, and it does make an interface look more polished. I’m afraid we can’t do anything about how they were implemented in Unicode. In any case, at least one new code point would have had to be added, since curly quotation marks have right and left versions, whereas there’s only one straight quotation mark. > Besides it makes it difficult to type. Slightly more difficult, yes. You can type curly double quotation marks with Level3+V and Level3+B. You can type single quotation marks with Level3+Shift+V and Level3+Shift+B. I have Level3 mapped to AltGr, so it’s pretty natural and having practiced it for a few weeks it’s now as easy as using straight quotation marks. However, it being easier to type should be no excuse: you write the string once, and it’s read a thousand times. Surely that makes it worth a bit more effort? :-) If, having read the linked page, you still don’t want to use curly quotation marks, please re-close the bug. I’ll get off my soap box now. :-(
(In reply to comment #20) > Attachment 254186 [details] pushed as 6962989 - UserLocation,MapLocation: Add translator > comments These comments doesn't show up in PO files. Using /* */ comments would help?
(In reply to comment #23) > (In reply to comment #20) > > Attachment 254186 [details] [details] pushed as 6962989 - UserLocation,MapLocation: Add translator > > comments > > These comments doesn't show up in PO files. Using /* */ comments would help? Yeah, unfortunately. :( Pushed a fix.
Comment on attachment 254037 [details] [review] strings: Use Unicode quotation marks and apostrophes Fine :)
Committed, thanks! commit 1fa5aea0444068de09d607ee67aeda70c0f8351c Author: Philip Withnall <philip@tecnocode.co.uk> Date: Tue Sep 3 22:27:49 2013 -0600 strings: Use Unicode quotation marks and apostrophes Also add a missing full stop in the appdata file. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=707437 data/gnome-maps.appdata.xml.in | 6 +++--- src/context-menu.ui | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) commit b7102701cf36af462f744add5f08f0457073895c Author: Philip Withnall <philip@tecnocode.co.uk> Date: Tue Sep 3 22:29:33 2013 -0600 data: Edit strings for clarity Minor changes. Helps: https://bugzilla.gnome.org/show_bug.cgi?id=707437 data/org.gnome.maps.gschema.xml.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Are you planning to branch gnome-3-10 before these commits?
(In reply to comment #27) > Are you planning to branch gnome-3-10 before these commits? I had branched already but had forgotten to push. Fixed now. Thanks.