GNOME Bugzilla – Bug 707435
Miscellaneous string fixes
Last modified: 2013-09-06 09:38:35 UTC
A few patches coming up to fix some string issues I spotted when doing the British English translation. Hopefully these are OK to commit as soon as GOA branches for 3.10, to avoid them rotting too much.
Created attachment 254031 [details] [review] goabackend: Use Unicode quotation marks instead of backticks Backticks should be banished to the 20th century. This also merges a couple of strings which differed only in the name of a data structure key (which shouldn’t be translated). Helps:
Created attachment 254032 [details] [review] goabackend: Combine three strings The strings only different in an XML element name, which shouldn’t be translated anyway. Helps:
Created attachment 254033 [details] [review] goabackend: Add translator comments for ‘Use for’ Helps:
Created attachment 254034 [details] [review] goabackend: Fix capitalisation of acronyms in some strings Helps:
Created attachment 254035 [details] [review] goabackend: Use Unicode em-dashes instead of hyphens Helps:
Created attachment 254036 [details] [review] goabackend: Use ‘log in’ rather than ‘login’ as a verb log in: verb, to authenticate login: noun, an identifier or account Closes:
Review of attachment 254031 [details] [review]: ::: src/goabackend/goaimapsmtpprovider.c @@ +392,3 @@ * is the error domain and code. */ + _("Invalid imap-password with username ‘%s’ (%s, %d): "), We should split "imap-password" out from the translated string, right? @@ +450,3 @@ * is the error domain and code. */ + _("Invalid smtp-password with username ‘%s’ (%s, %d): "), And "smtp-password" in this case.
Review of attachment 254032 [details] [review]: Looks good.
Review of attachment 254033 [details] [review]: Looks good. This might help ameliorate the problem in bug 686090 but the real solution there is not to split the strings.
Review of attachment 254034 [details] [review]: Given that we are not looking for something that is actually called 'guid', except for Yahoo, how about we take this opportunity to use something else instead of GUID or user ID? eg., "your identity".
Review of attachment 254035 [details] [review]: Looks good.
Review of attachment 254036 [details] [review]: Looks good, but you should drop this part: diff --git a/telepathy-account-widgets b/telepathy-account-widgets index c7c5ffe..884bf56 160000 --- a/telepathy-account-widgets +++ b/telepathy-account-widgets @@ -1 +1 @@ -Subproject commit c7c5ffe921566ca7f502ba96913d5c0ebadc14a9 +Subproject commit 884bf560b4c985fb813d8153ae1cb8a4960193ee
Created attachment 254093 [details] [review] goabackend: Use Unicode quotation marks instead of backticks Backticks should be banished to the 20th century. This also merges a couple of strings which differed only in the name of a data structure key (which shouldn’t be translated). Helps:
Created attachment 254094 [details] [review] goabackend: Fix capitalisation of acronyms in some strings Remove the acronyms and use ‘your identity’ instead. This merges a couple of strings and makes them a bit clearer to the user. Helps:
Created attachment 254095 [details] [review] goabackend: Use ‘log in’ rather than ‘login’ as a verb log in: verb, to authenticate login: noun, an identifier or account Closes:
Review of attachment 254093 [details] [review]: Looks good.
Review of attachment 254094 [details] [review]: Looks good.
Review of attachment 254095 [details] [review]: Looks good.