After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707426 - master is broken in picking up flavour from configure.ac
master is broken in picking up flavour from configure.ac
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal blocker
: 1.20
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-03 22:11 UTC by Behdad Esfahbod
Modified: 2014-02-09 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rearrange GTK_DOC_CHECK handling to before argument parsing (4.07 KB, patch)
2013-09-05 18:41 UTC, David King
committed Details | Review
gtkdocize: Fix GTK_DOC_CHECK argument handling (4.07 KB, patch)
2013-09-05 19:08 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Behdad Esfahbod 2013-09-03 22:11:03 UTC
This commit:

Author: David King <amigadave@amigadave.com>  2013-01-23 08:30:20
Committer: Stefan Sauer <ensonic@users.sf.net>  2013-08-18 07:34:25
Parent: 6f04348705e4fe05a30ca3bbf9bef27749e24b14 (gtk-doc.make: Fix "-chmod: command not found")
Child:  5bf7cdca8ff16697f9061c695f02293b6b44488d (configure.ac: use the right quoting for the date check)
Branches: master, remotes/origin/master
Follows: GTK_DOC_1_19
Precedes: 

    gtkdocize: Take a --srcdir argument
    
    https://bugzilla.gnome.org/show_bug.cgi?id=692367

Moves the code picking up arguments from configure.ac to AFTER the code picking up makefile flavour.  As a results, the flavour is never picked up from configure.ac, resulting in legacy flavour makefile to be used.
Comment 1 David King 2013-09-05 18:41:55 UTC
Created attachment 254205 [details] [review]
rearrange GTK_DOC_CHECK handling to before argument parsing

The attached patch seems to fix the problem for me.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2013-09-05 19:08:07 UTC
The following fix has been pushed:
d59906d gtkdocize: Fix GTK_DOC_CHECK argument handling
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2013-09-05 19:08:14 UTC
Created attachment 254206 [details] [review]
gtkdocize: Fix GTK_DOC_CHECK argument handling

After commit 1401aebc625dd1c7c39457d3455dce3019ded0be, any extra
arguments passed to gtkdocize by GTK_DOC_CHECK in configure.ac were
ignored. This broke because the arguments to GTK_DOC_CHECK are injected
into the argument for gtkdocize, but the rearrangement to add --srcdir
support pushed the injection down to after where the arguments were
parsed.

Fix the argument handling by checking for a --srcdir agument (and for
GTK_DOC_CHECK) before parsing other arguments.