GNOME Bugzilla – Bug 707424
Use autoconf tracing instead of looking inside configure.ac
Last modified: 2014-12-29 14:56:11 UTC
Eg. behdad:hb 0 (master*)$ autoconf --trace GTK_DOC_CHECK ./configure.ac configure.ac:57:GTK_DOC_CHECK:1.15:--flavour no-tmpl behdad:hb 0 (master*)$ autoconf --trace GTK_DOC_CHECK:'$1' ./configure.ac 1.15 behdad:hb 0 (master*)$ autoconf --trace GTK_DOC_CHECK:'$2' ./configure.ac --flavour no-tmpl
Created attachment 254210 [details] [review] use autoconf --trace for AC_CONFIG_MACRO_DIR This is a really neat idea, but I do not think that it will work for the GTK_DOC_CHECK case in gtkdocize, as GTK_DOC_CHECK needs to be in aclocal.m4. You can verify this by doing the --trace on a fresh git clone, which gives no output. It would be possible to use the tracing for AC_CONFIG_MACRO_DIR, so I attached a patch which does just that. I tested this and it seems to work fine (and for --srcdir too), but more testing would be appreciated.
The patch seems to be a nice simplification. Although: > echo `autoconf --trace 'AC_CONFIG_MACRO_DIR:$1' configure.ac ` configure.ac:57: warning: LT_INIT was called before AM_PROG_AR aclocal.m4:235: AM_PROG_AR is expanded from... configure.ac:57: the top level m4 So maybe it should be: > echo `autoconf 2>/dev/null --trace 'AC_CONFIG_MACRO_DIR:$1' configure.ac ` m4 Apart from the simplification, is there some other benefit?
The following fix has been pushed: 507662a gtkdocize: Use autoconf --trace for AC_CONFIG_MACRO_DIR
Created attachment 293441 [details] [review] gtkdocize: Use autoconf --trace for AC_CONFIG_MACRO_DIR