After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707376 - Set the position of the view scrollbar to current song when a song is changed
Set the position of the view scrollbar to current song when a song is changed
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-03 12:15 UTC by Sai Suman Prayaga
Modified: 2014-03-03 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Scroll to current song when a song is changed (857 bytes, patch)
2014-03-03 15:47 UTC, Anton Belka
needs-work Details | Review
[PATCH] Scroll to current song when a song is changed (855 bytes, patch)
2014-03-03 16:10 UTC, Anton Belka
committed Details | Review

Description Sai Suman Prayaga 2013-09-03 12:15:43 UTC
When in songs view, If there is a large collection of songs It would be nice to know which song is currently being played from the entire collection. The position of the scrollbar should be set to the position of current song whenever a song is changed.
Comment 1 Arnel Borja 2013-09-03 12:18:30 UTC
I agree on this feature.
Comment 2 Vadim Rutkovsky 2014-03-03 11:27:40 UTC
This one looks simple, use scroll_to_path() function
Comment 3 Anton Belka 2014-03-03 15:47:58 UTC
Created attachment 270817 [details] [review]
[PATCH] Scroll to current song when a song is changed
Comment 4 Vadim Rutkovsky 2014-03-03 15:50:33 UTC
Review of attachment 270817 [details] [review]:

This uses currentIter instead filter's iter, so it might probably crash. Also get_model() is not required there - self._model is enough
Comment 5 Anton Belka 2014-03-03 16:10:46 UTC
Created attachment 270818 [details] [review]
[PATCH] Scroll to current song when a song is changed

Fixed
Comment 6 Vadim Rutkovsky 2014-03-03 16:36:06 UTC
Review of attachment 270818 [details] [review]:

Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=2fd0437