After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707374 - New account dialog should use "Cancel", not "Close"
New account dialog should use "Cancel", not "Close"
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: tp-aw
unspecified
Other All
: Normal normal
: ---
Assigned To: Marco Barisione
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-03 11:17 UTC by Marco Barisione
Modified: 2018-05-22 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marco Barisione 2013-09-03 11:17:57 UTC
In the rush to finish everything for 3.10 we didn't have enough time to polish the UI. We should improve it more for 3.10.

This is Allan's original comment on bug #706148:
Fly by design review based on Marco's screenshots...

http://people.collabora.com/~bari/tmp-goa-empathy/accounts.png

 * Jabber accounts should use user-status-available-symbolic for the icon
(since they are generic)
 * Maybe it should say XMPP and not Jabber?
 * Needs more (12px ?) padding above the Chat switch
 * "Use for" and "Chat" should be vertically aligned
 * "Edit Connection Parameters..." > "Connection Settings"
 * "Edit Personal Details..." > "Personal Details"

http://people.collabora.com/~bari/tmp-goa-empathy/edit-connection-parameters.png

 * It would be much better to have these fields 
 * "Edit Connection Parameters" > "Connection Settings"
 * Text fields should be wider (about 280px)
 * Add more padding above the password field (maybe just 6px)
 * "Remember password" > "Remember Password"
 * Do you really need the clear button in the password field? If yes, please
use edit-clear-symbolic for the icon
 * I dread to think what's under Advanced Settings ;)
 * Needs extra padding (12px) below Advance Settings

http://people.collabora.com/~bari/tmp-goa-empathy/edit-personal-details.png

 * "Edit Personal Details" > "Personal Details"
 * Would benefit from an explanation at the top: "These details will be shared
with other users on this chat network"
 * Use title case for field labels
 * Use edit-clear-symbolic for the clear button icon
 * Needs more padding above the Cancel/OK buttons - add 12px

http://people.collabora.com/~bari/tmp-goa-empathy/add-account1.png

 * I'm worried that we're overloading this list. Will this be revisited next
cycle?

http://people.collabora.com/~bari/tmp-goa-empathy/add-account2.png

 * Why is the layout different from connection settings? Lots of alignment
issues here - would be fixed by following the connections settings layout.
 * Odd phrasing in labels, eg. "What is your Jabber ID?"
 * "Log In" > "Add"
Comment 1 Marco Barisione 2013-09-03 11:26:21 UTC
Some fixes already landed for 3.10.

(In reply to comment #0)
>  * Jabber accounts should use user-status-available-symbolic for the icon
> (since they are generic)

Lots of the accounts are generic. I think it would be a bit confusing. But I guess this depends on what we do with that long list anyway.

>  * Maybe it should say XMPP and not Jabber?

Not sure. I know that Pidgin says XMPP, but for Empathy we always say Jabber.

>  * Needs more (12px ?) padding above the Chat switch
>  * "Use for" and "Chat" should be vertically aligned

These don't come from this backend. The UI in the screenshots is a bit messy, but not on a real system. I guess it depends on running jhbuild built stuff on a 3.8 session.

>  * "Edit Connection Parameters..." > "Connection Settings"

Done.

>  * "Edit Personal Details..." > "Personal Details"

Done.

> http://people.collabora.com/~bari/tmp-goa-empathy/edit-connection-parameters.png
> 
>  * It would be much better to have these fields

Hm?

>  * "Edit Connection Parameters" > "Connection Settings"

Done.

>  * Text fields should be wider (about 280px)

Done (and I also made sure that they expand horizontally correctly).

>  * Add more padding above the password field (maybe just 6px)

Done.

>  * "Remember password" > "Remember Password"

Forgot to do it for 3.10.

>  * Do you really need the clear button in the password field? If yes, please
> use edit-clear-symbolic for the icon

Done (the clear is needed because an empty password is different from an unset one).

>  * I dread to think what's under Advanced Settings ;)

I improved it a little bit for most protocols. Still not pretty.

>  * Needs extra padding (12px) below Advance Settings

Done.


> http://people.collabora.com/~bari/tmp-goa-empathy/edit-personal-details.png
> 
>  * "Edit Personal Details" > "Personal Details"

Done.

>  * Would benefit from an explanation at the top: "These details will be shared
> with other users on this chat network"

Done.

>  * Use title case for field labels

Done.

>  * Use edit-clear-symbolic for the clear button icon

Done.

>  * Needs more padding above the Cancel/OK buttons - add 12px

Done.

> http://people.collabora.com/~bari/tmp-goa-empathy/add-account1.png
> 
>  * I'm worried that we're overloading this list. Will this be revisited next
> cycle?

Feel free to suggest improvements.

> http://people.collabora.com/~bari/tmp-goa-empathy/add-account2.png
> 
>  * Why is the layout different from connection settings? Lots of alignment
> issues here - would be fixed by following the connections settings layout.
>  * Odd phrasing in labels, eg. "What is your Jabber ID?"
>  * "Log In" > "Add"

Replaced with the normal dialog.
Comment 2 Marco Barisione 2013-09-03 14:49:50 UTC
I also noticed that the new account dialog uses a "Close" button instead of a "Cancel" one. I should fix that too.
Comment 3 Debarshi Ray 2017-01-06 17:45:25 UTC
Given that Telepathy is very very weakly maintained, I am going to drastically reduce the scope of this bug to only cover comment 2.

Eventually this will have to reassigned to the telepathy-account-widgets submodule.
Comment 4 Debarshi Ray 2018-04-17 10:14:04 UTC
The Telepathy provider is being dropped from gnome-online-accounts (bug 795322). Re-assigning to empathy since that's the only user of this code, and also that's where all telepathy-account-widgets bugs are tracked.
Comment 5 GNOME Infrastructure Team 2018-05-22 16:18:51 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/736.