After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707333 - qtmux: handle buffers with missing duration properly
qtmux: handle buffers with missing duration properly
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-02 23:36 UTC by Matej Knopp
Modified: 2013-09-03 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.01 KB, patch)
2013-09-02 23:36 UTC, Matej Knopp 		needs-work Details | Review

Description Matej Knopp 2013-09-02 23:36:46 UTC 
Created attachment 253909 [details] [review]
patch

Right now everything mostly works, as duration for samples is computed as DTS delta, except for last buffer where it'd duration is used for calculation (without checking for validity). This results in files with ether extremely short or extremely long reported streams with is not very good.

Patch simply sets duration for last buffer to 0 if none is set on buffer.
Comment 1 Matej Knopp 2013-09-02 23:52:57 UTC 
Review of attachment 253909 [details] [review]:

Forgot to stage some lines
Comment 2 Sebastian Dröge (slomo) 2013-09-03 08:21:16 UTC 
Sounds sensible though :)
Comment 3 Matej Knopp 2013-09-03 17:55:02 UTC 
I'll add it to patch in #707340