After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707332 - videoencoder: doesn't check for invalid duration
videoencoder: doesn't check for invalid duration
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-02 22:50 UTC by Matej Knopp
Modified: 2013-09-18 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.16 KB, patch)
2013-09-02 22:50 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2013-09-02 22:50:21 UTC 
Created attachment 253908 [details] [review]
Patch

it clips buffer with invalid duration resulting in cstop being GST_CLOCK_TIME_NONE and then later uses cstop in calculation.
Comment 1 Sebastian Dröge (slomo) 2013-09-03 07:54:31 UTC 
commit d03feedf4c15e4af7b4ffed4b073772825797b6d
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Tue Sep 3 00:47:18 2013 +0200

    videoencoder: Check for invalid stop position before calculating a duration from it
    
    https://bugzilla.gnome.org/show_bug.cgi?id=707332


(Checking if cstart is valid was not necessary)