After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707295 - Border-radius of overview-icons in app picker doesn't match rounded edges of running-indicator
Border-radius of overview-icons in app picker doesn't match rounded edges of ...
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: overview
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-02 16:11 UTC by Florian Müllner
Modified: 2015-02-27 05:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
border-radius for overview-icons to match with rounded edges of running-indicator.svg (1.41 KB, patch)
2013-09-02 16:11 UTC, Florian Müllner
needs-work Details | Review

Description Florian Müllner 2013-09-02 16:11:19 UTC
This patch was originally filed in bug 706081, but that's already huge as is, so better create a separate report for it.
Comment 1 Florian Müllner 2013-09-02 16:11:22 UTC
Created attachment 253859 [details] [review]
border-radius for overview-icons to match with rounded edges of running-indicator.svg
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-02 16:29:01 UTC
Review of attachment 253859 [details] [review]:

Looks good.
Comment 3 Carlos Soriano 2013-09-13 09:32:08 UTC
The problem of not matching rounded corners with the svg is not a problem of the border-radius, since a border radius of 4px has to work everywhere (no sense to have 4px of border radius in dash and 10px radius in app-pciker with the same svg)

The problem is that the runing-indicator.svg is separated from the bottom, so that makes that in app picker, the rounded edges doesn't match.

In dash it is working because of a problem, the svg is bad allocated 1 or 2 px to the bottom, being cut off. That's why the svg matchs in dash and not in app-picker.
So we have to take a look why the svg is not allocated fine.
Comment 4 Bastien Nocera 2014-11-07 09:17:38 UTC
Comment on attachment 253859 [details] [review]
border-radius for overview-icons to match with rounded edges of running-indicator.svg

This patch conflicts with the patch from bug https://bugzilla.gnome.org/show_bug.cgi?id=699044
Comment 5 Florian Müllner 2015-02-27 05:10:18 UTC
The old running indicator is gone, closing.