After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707280 - Fix GObject signal methods to work with new annotations
Fix GObject signal methods to work with new annotations
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-02 11:12 UTC by Simon Feltman
Modified: 2013-09-02 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix GObject signal methods to work with new annotations (7.76 KB, patch)
2013-09-02 11:22 UTC, Simon Feltman 		none Details | Review

Description Simon Feltman 2013-09-02 11:12:44 UTC 
The new GLib signal annotations break our overrides (bug #685387). Fix these with a conditional check to support old and new annotations.
Comment 1 Simon Feltman 2013-09-02 11:22:58 UTC 
Created attachment 253828 [details] [review]
Fix GObject signal methods to work with new annotations

Add conditional support for signal methods annotated as gpointer
or GObject.Object. This is needed to work with newer versions of
glib which changed annotations to GObject.Object (bug #685387).

Notes:
Tested with Python 2.7 and 3.3 both with and without new annotations.
Comment 2 Martin Pitt 2013-09-02 12:28:20 UTC 
Thanks Simon! Works fine here as well, and LGTM.