After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707268 - Use officially released Vala bindings for libgweather
Use officially released Vala bindings for libgweather
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-02 07:58 UTC by Evgeny Bobkin
Modified: 2013-09-02 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch proposal for gweather port (12.29 KB, patch)
2013-09-02 07:59 UTC, Evgeny Bobkin 		none Details | Review
patch proposal for gweather port (12.26 KB, patch)
2013-09-02 17:59 UTC, Evgeny Bobkin 		committed Details | Review

Description Evgeny Bobkin 2013-09-02 07:58:13 UTC 
vala bindings have been added.
Comment 1 Evgeny Bobkin 2013-09-02 07:59:50 UTC 
Created attachment 253807 [details] [review]
patch proposal for gweather port
Comment 2 Paolo Borelli 2013-09-02 17:52:24 UTC 
Review of attachment 253807 [details] [review]:

Just a small nitpicj and then push!

::: src/world.vala
@@ -149,1 +149,1 @@
         // it returns the same instance after the first call

Remove the comments, now that we are not using "new" they are not needed anymore
Comment 3 Evgeny Bobkin 2013-09-02 17:59:05 UTC 
Created attachment 253873 [details] [review]
patch proposal for gweather port