After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707264 - Fix build of gi/pygi-closure.c on C89 compilers
Fix build of gi/pygi-closure.c on C89 compilers
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
3.9.x
Other Windows
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-02 06:42 UTC by Fan, Chun-wei
Modified: 2013-09-02 07:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid variable declarations in the middle of the block (946 bytes, application/octet-stream)
2013-09-02 06:42 UTC, Fan, Chun-wei 		  Details
Avoid variable declarations in the middle of the block (946 bytes, patch)
2013-09-02 06:44 UTC, Fan, Chun-wei 		none Details | Review

Description Fan, Chun-wei 2013-09-02 06:42:44 UTC 
Created attachment 253803 [details]
Avoid variable declarations in the middle of the block

Hi,

As we were checking whether _pygi_argument_from_object had error(s) occuring (commit ec3de760), this made a variable declaration go into the middle of the block, which made C89 compilers complaining.  This simple patch addresses this.

With blessings, thank you!
Comment 1 Fan, Chun-wei 2013-09-02 06:44:20 UTC 
Created attachment 253804 [details] [review]
Avoid variable declarations in the middle of the block
Comment 2 Martin Pitt 2013-09-02 07:38:51 UTC 
Thanks! Pushed.