After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707212 - Mnemonics conflict in delete-confirmation dialog.
Mnemonics conflict in delete-confirmation dialog.
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.9.x
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-01 09:39 UTC by Jiro Matsuzawa
Modified: 2013-09-01 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot showing this bug (10.02 KB, image/png)
2013-09-01 09:39 UTC, Jiro Matsuzawa 		  Details
Change mnemonic to avoid confliction (1.48 KB, patch)
2013-09-01 09:47 UTC, Jiro Matsuzawa 		none Details | Review

Description Jiro Matsuzawa 2013-09-01 09:39:42 UTC 
Created attachment 253739 [details]
Screenshot showing this bug

In the delete-confirmation dialog, the message of the checkbox ("_Do not ask...") and that of the delete button ("_Delete") have "D" as its mnemonic in common. Refer to the attached screenshot. They should be different from each other.
Comment 1 Jiro Matsuzawa 2013-09-01 09:47:41 UTC 
Created attachment 253740 [details] [review]
Change mnemonic to avoid confliction

I changed "Do not ask..." to use "N". The message exists at two parts. Although the latter may not need to be changed, I believe that they should be the same message.
Comment 2 Felix Riemann 2013-09-01 10:38:50 UTC 
Nice catch!
I took the chance and stripped both dialogs of their GtkStock usage, to make it clearer which widget uses which mnemonic.

commit 0ffced37f62338300b5ede4ed0a678fadb5d0294
Author: Jiro Matsuzawa <
Date:   Sun Sep 1 18:27:48 2013 +0900

    Change mnemonic to avoid confliction
    
    https://bugzilla.gnome.org/show_bug.cgi?id=707212

---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.