After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707208 - menu does not appear translated
menu does not appear translated
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-01 05:49 UTC by Seán de Búrca
Modified: 2013-09-03 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix i18n (5.71 KB, patch)
2013-09-03 10:28 UTC, Seán de Búrca
rejected Details | Review
builder: use the correct translation domain (3.71 KB, patch)
2013-09-03 14:57 UTC, Marco Barisione
committed Details | Review

Description Seán de Búrca 2013-09-01 05:49:48 UTC
The main application menu is not translated in empathy-3.9.90, despite the strings being correctly localized. All locales tested exhibited this behavior.
Comment 1 Seán de Búrca 2013-09-02 09:38:24 UTC
I ran git-bisect against the tree and discovered that https://git.gnome.org/browse/empathy/commit/?id=3d1021753d01d973c929c8758b11a147498377cc was the culprit commit. However, I'm not clear how this affected the menu, especially as not all strings are affected. (The status list, for example, is translated correctly.)
Comment 2 Seán de Búrca 2013-09-03 10:20:45 UTC
It appears that this is caused by lack of translation domain in the GtkBuilder files. I will submit a patch later today to correct this.
Comment 3 Seán de Búrca 2013-09-03 10:28:02 UTC
Created attachment 253946 [details] [review]
Fix i18n

I manually tested adding domain="empathy" to empathy-roster-window-menubar.ui. It corrected the menu strings. I have corrected the domain in all GtkBuilder files in src/ to solve similar problems there. I'm unsure why pulling TPAW out of tree caused this problem to appear, but this appears to be the root cause.
Comment 4 Marco Barisione 2013-09-03 14:57:36 UTC
Created attachment 253984 [details] [review]
builder: use the correct translation domain

tpaw_builder_get_*() functions always used GETTEXT_PACKAGE as
translation domain, but that always meant the tpaw one so it broke
empathy's translations.

This commit adds tpaw_builder_get_*_with_domain() functions and replace
the previous functions with macros that use the GETTEXT_PACKAGE defined
in the .c file that includes tpaw-builder.h.
Comment 5 Guillaume Desmottes 2013-09-03 14:59:48 UTC
Review of attachment 253984 [details] [review]:

++
Comment 6 Marco Barisione 2013-09-03 15:00:03 UTC
Seán: thanks, your comments made me understand what went wrong. I think that a better approach would be the one I just attached, so we don't have to modify all the .ui files.
Comment 7 Guillaume Desmottes 2013-09-03 15:08:17 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.