GNOME Bugzilla – Bug 707135
String fixes for the "Export Complete Key" buttons in the Seahorse UI
Last modified: 2018-08-03 19:30:02 UTC
Created attachment 253626 [details] [review] String fix in ssh/seahorse-ssh-key-properties.xml Select a GnuPG/SSH personal key. Right click the selected key and select Properties->Details. The Export Complete Key button should have the string "Export Secret Key" because the button exports the secret key in an SSH/GnuPG keypair into a keyfile. The same can be verified by checking the contents of the exported keyfile. The keyfile contains the contents of the secret PGP key/secret SHA for SSH keys. The attached patches replace the faulty strings in both the SSH UI and the PGP UI with "Export Secret Key". P.S. - In the case of the GnuPG keys, the "Export Secret Key" is only a label, while the button to export simply says "Export". I suggest removing the label altogether and replacing the string on the button with Export Secret Key so that it is more compliant with the SSH key export dialog. I would like to work on a patch for the same, if the idea sounds okay.
Created attachment 253627 [details] [review] String fix in pgp/seahorse-pgp-private-key-properties.xml This patch fixes the string for the button inside the dialog to export PGP keys.
Review of attachment 253626 [details] [review]: Unfortunately SSH keys don't have a 'secret' key, they have a 'private' key. See 'man ssh-keygen'
Created attachment 254607 [details] [review] String fix in ssh/seahorse-ssh-key-properties.xml Fixed patch to change secret key->private key.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/seahorse/issues/89.