GNOME Bugzilla – Bug 707112
[PATCH] Replace webkit_dom_html_element_get_id usage
Last modified: 2013-11-04 21:13:49 UTC
Created attachment 253583 [details] [review] Patch replacing webkit_dom_element_get_id Replace webkit_dom_html_element_get_id with webkit_dom_element_get_id; the former is deprecated. See https://trac.webkit.org/changeset/154788 .
Created attachment 253584 [details] [review] Patch replacing webkit_dom_element_{get,set}_id
Derp. There was one instance of webkit_dom_html_element_set_id that needed to be replaced; patch updated.
Thanks for the patch. Evolution currently requires only WebKitGTK 1.10 or later. When was webkit_dom_element_{get,set}_id introduced? I want to make sure we're only using APIs that are present in our minimum WebKitGTK requirement. If necessary, we can raise our minimum requirement for Evolution 3.11.
Review of attachment 253584 [details] [review]: I tried building Evolution with the patch applied against WebKitGTK versions 1.10.2 and 2.0.4 (latest stable release), and both attempts failed. So it appears this API was very recently introduced and exceeds our present WebKitGTK requirement for building Evolution. The patch itself looks correct but it's going to have to wait until our minimum WebKitGTK requirement catches up. (Requires webkitgtk-3.0 >= 2.2)
*** Bug 707413 has been marked as a duplicate of this bug. ***
*** Bug 709142 has been marked as a duplicate of this bug. ***
Committed the patch with a conditional version check to silence the misguided runtime warnings from WebKit. Fixed for Evolution 3.11.2 and 3.10.2: https://git.gnome.org/browse/evolution/commit/?id=7063a2871097bd62140655a2a0cc8f4e300db4c4 https://git.gnome.org/browse/evolution/commit/?h=gnome-3-10&id=34e11a50a729a767c3830482d8d7dccc98af91d3