GNOME Bugzilla – Bug 707095
lock screen (without lock) inhibits suspend by power button
Last modified: 2013-11-08 13:33:29 UTC
the screen shield inhibits suspending by the physical power button. I have to unlock / unshield the screen before I can suspend the desktop with the power button. This does not feel intuitive nor desired to me.
I'm not sure it's intuitive or not, but anyway it's up to gnome-settings-daemon to request a different behavior.
If we want this, we will need some patches on the gnome-shell side as well I think - as far as I can see, screen shield uses the 'lock-screen' session mode regardless of whether the screen will actually be locked or not ...
(In reply to comment #2) > If we want this, we will need some patches on the gnome-shell side as well I > think - as far as I can see, screen shield uses the 'lock-screen' session mode > regardless of whether the screen will actually be locked or not ... I don't understand why it would need gnome-shell changes. And while I agree that being able to press the power button to suspend is nice, the problem is that the power button is (still!) configurable, so you could potentially use it to shutdown the machine (with all the sort of warning dialogues that you don't want to see in a lock screen). Can we remove the configuration for those darn buttons instead?
(In reply to comment #3) > I don't understand why it would need gnome-shell changes. Because the report asks for the power button to work when the screen shield is showing while not being locked (e.g. lock is disabled).
(In reply to comment #4) > (In reply to comment #3) > > I don't understand why it would need gnome-shell changes. > > Because the report asks for the power button to work when the screen shield is > showing while not being locked (e.g. lock is disabled). I still don't understand how that makes a difference... Because gnome-shell should transition to a locked screen shield when suspending? This should already be a transition it handles (eg. it's already a code path that could be taken if we ask the g-s-d power plugin to suspend on low battery, or when unused).
(In reply to comment #5) > > Because the report asks for the power button to work when the screen shield is > > showing while not being locked (e.g. lock is disabled). > > I still don't understand how that makes a difference... Because gnome-shell > should transition to a locked screen shield when suspending? No, because both the locked and unlocked shield use SHELL_KEYBINDING_MODE_LOCK_SCREEN. I guess you can set up the power button to work on the lock screen and check in the handler if the screen is actually locked and don't perform any action in that case - sounds ugly to me, but in that case you could indeed do without any changes on the shell side :-)
That is, if we wanted to be able to stop suspending using the power button when the screen lock was on. I don't see a reason to do that. If the person was in front of the computer, they could already hold that button to switch it off.
(In reply to comment #7) > If the person was in front of the computer, they could already hold > that button to switch it off. Oh, true - I rest my case then :-)
Created attachment 259099 [details] [review] media-keys: Allow the power key in more places We allow using the power key pretty much everywhere now, but we also ensure that we never show interactive dialogues on the lock screen (something that was possible with other suspend/power buttons already if more than more than one user was logged in, or an interactive shutdown was configured). See https://bugzilla.redhat.com/show_bug.cgi?id=980692
Review of attachment 259099 [details] [review]: LGTM
Attachment 259099 [details] pushed as b7827c1 - media-keys: Allow the power key in more places
This doesn't currently work due to some limitations in gnome-shell, see bug 711682