GNOME Bugzilla – Bug 707076
Selecting items with some favorites sets all selected as favorites
Last modified: 2016-03-31 13:22:07 UTC
Selecting a machine not in favorites, while there is a machine that is in favorites and selected, adds all selected items to favorites. This happens because the active property is changed during the check for selection, emitting a "clicked" signal. If all are set as favorites, selecting a machine don't work. To reproduce: 1. Select a machine then add to favorites. 2. Close selection mode. 3. Select again the previous machine. 4. Select another machine that is not in favorites. Result: The new selected machine gets added to favorites Expected: The new selected machine should not be in favorites
Created attachment 253542 [details] [review] selectionbar: Fix selection bug on favorites Selecting a machine not in favorites, while there is a machine that is in favorites and selected, adds all selected items to favorites. This happens because the active property is changed during the check for selection, emitting a "clicked" signal. This patch will block the "clicked" handler for favorite button while changing this property.
Review of attachment 253542 [details] [review]: Looks good otherwise. Feel free to add comment just before pushing. ::: src/selectionbar.vala @@ +99,3 @@ } + SignalHandler.block (favorite_btn, favorite_btn_clicked_handler); Please add a small comment above this line about why you are blocking the signal.
Comment on attachment 253542 [details] [review] selectionbar: Fix selection bug on favorites Committed as 18e91d9