After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707065 - CreateReference failed in Playlist subfolder
CreateReference failed in Playlist subfolder
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-server
0.19.x
Other Linux
: Normal major
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-29 16:10 UTC by Ludovic Ferrandis
Modified: 2013-09-28 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
server: No OCM flags checking for CreateReference (1.62 KB, patch)
2013-09-03 08:49 UTC, Jens Georg 		none Details | Review

Description Ludovic Ferrandis 2013-08-29 16:10:29 UTC 
1 - Create a folder under Playlist root folder
2 - Create a reference in this new folder

=> Error.

(lt-rygel:20789): Rygel-WARNING **: Failed to create object under 'playlist:fbbedbd6-86da-4e02-85f9-998b818fda7d': Object creation in playlist:fbbedbd6-86da-4e02-85f9-998b818fda7d not allowed

Issue is in src/librygel-server/rygel-reference-creator.vala, fetch_container(), the test of OCMFlags.UPLOAD failed.

=> The new folder has only the DELETE flag set to 1.
Comment 1 Jens Georg 2013-09-03 08:49:50 UTC 
Created attachment 253933 [details] [review]
server: No OCM flags checking for CreateReference

There's no DLNA guidelines for reference creation, however if a container only
supports reference creation such as MediaExport's playlist containers, it
mustn't have the UPLOAD OCM flag set.

So we just check for writable container and let the creation fail later on in
the container if it's not allowed to have references there.
Comment 2 Jens Georg 2013-09-28 10:59:22 UTC 
pushed as faa7ec85a9832193ddab50a74ad986da8592b426