After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707056 - Use new close button in GtkHeaderBar
Use new close button in GtkHeaderBar
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-29 14:43 UTC by Yosef Or Boczko
Modified: 2013-08-29 23:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mainToolbar: Use new close button in GtkHeaderBar (3.68 KB, patch)
2013-08-29 14:43 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-08-29 14:43:59 UTC 
Created attachment 253515 [details] [review]
mainToolbar: Use new close button in GtkHeaderBar

See patch.
Comment 1 Pierre-Yves Luyten 2013-08-29 23:10:10 UTC 
Comment on attachment 253515 [details] [review]
mainToolbar: Use new close button in GtkHeaderBar

The patch is good, you can commit


>-  g_signal_connect (priv->close,"clicked",
>-                    G_CALLBACK(on_close_clicked), self);
>-}
>-
>-

another patch can remove the "on_close_clicked" callback
Comment 2 Yosef Or Boczko 2013-08-29 23:28:57 UTC 
Review of attachment 253515 [details] [review]:

pushed as cbe17030a1f547adcf2c65af03b8e81d7da964fe - mainToolbar: Use new close button in GtkHeaderBar
Comment 3 Yosef Or Boczko 2013-08-29 23:29:45 UTC 
(In reply to comment #1)
> (From update of attachment 253515 [details] [review])
> The patch is good, you can commit
> 
> 
> >-  g_signal_connect (priv->close,"clicked",
> >-                    G_CALLBACK(on_close_clicked), self);
> >-}
> >-
> >-
> 
> another patch can remove the "on_close_clicked" callback

This in cbe17030a1f547adcf2c65af03b8e81d7da964fe.